RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:57:44 +00:00
Code Issues Activity Actions

Everywhere: Fix -Winconsistent-missing-override warnings from Clang

Browse source 
This option is already enabled when building Lagom, so let's enable it
for the main build too. We will no longer be surprised by Lagom Clang
CI builds failing while everything compiles locally.

Furthermore, the stronger `-Wsuggest-override` warning is enabled in
this commit, which enforces the use of the `override` keyword in all
classes, not just those which already have some methods marked as
`override`. This works with both GCC and Clang.
This commit is contained in:
Daniel Bertalan 2021-12-04 10:09:09 +01:00 • committed by Brian Gianforcaro
parent 813593a485
commit 4a81b33c07
22 changed files with 45 additions and 45 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/Terminal/main.cpp
View file

@ -51,7 +51,7 @@ public:
{
}
virtual void config_string_did_change(String const& domain, String const& group, String const& key, String const& value)
virtual void config_string_did_change(String const& domain, String const& group, String const& key, String const& value) override
{
VERIFY(domain == "Terminal");
@ -77,7 +77,7 @@ public:
}
}
virtual void config_i32_did_change(String const& domain, String const& group, String const& key, i32 value)
virtual void config_i32_did_change(String const& domain, String const& group, String const& key, i32 value) override
{
VERIFY(domain == "Terminal");