mirror of
https://github.com/RGBCube/serenity
synced 2025-07-27 01:27:34 +00:00
Everywhere: Remove needless copies of Error / ErrorOr instances
Either take the underlying objects with release_* methods or move() the instances around.
This commit is contained in:
parent
52687814ea
commit
4a916cd379
28 changed files with 69 additions and 77 deletions
|
@ -85,7 +85,7 @@ void PlaybackManager::dispatch_fatal_error(Error error)
|
|||
// FIXME: For threading, this will have to use a pre-allocated event to send to the main loop
|
||||
// to be able to gracefully handle OOM.
|
||||
VERIFY(&m_main_loop == &Core::EventLoop::current());
|
||||
FatalPlaybackErrorEvent event { error };
|
||||
FatalPlaybackErrorEvent event { move(error) };
|
||||
m_event_handler.dispatch_event(event);
|
||||
}
|
||||
|
||||
|
|
|
@ -247,11 +247,11 @@ class FatalPlaybackErrorEvent : public Core::Event {
|
|||
public:
|
||||
explicit FatalPlaybackErrorEvent(Error error)
|
||||
: Core::Event(FatalPlaybackError)
|
||||
, m_error(error)
|
||||
, m_error(move(error))
|
||||
{
|
||||
}
|
||||
virtual ~FatalPlaybackErrorEvent() = default;
|
||||
Error error() { return m_error; }
|
||||
Error const& error() { return m_error; }
|
||||
|
||||
private:
|
||||
Error m_error;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue