RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:57:45 +00:00
Code Issues Activity Actions

LibIPC: Remove requirement that Variant types must begin with Empty

Browse source 
This is no longer required by the decoder.
This commit is contained in:
Timothy Flynn 2022-12-22 21:29:36 -05:00 • committed by Andreas Kling
parent 9b483625e6
commit 4abafbbe3c
1 changed files with 1 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibIPC/Encoder.h
View file

@ -89,12 +89,9 @@ public:
return *this; return *this;
} }
// Note: We require any encodeable variant to have Empty as its first variant, as only possibly-empty variants can be default constructed.
// The default constructability is required by generated IPC message marshalling code.
template<typename... VariantTypes> template<typename... VariantTypes>
Encoder& operator<<(AK::Variant<AK::Empty, VariantTypes...> const& variant) Encoder& operator<<(AK::Variant<VariantTypes...> const& variant)
{ {
// Note: This might be either u8 or size_t depending on the size of the variant; both are encodeable.
*this << variant.index(); *this << variant.index();
variant.visit([this](auto const& underlying_value) { *this << underlying_value; }); variant.visit([this](auto const& underlying_value) { *this << underlying_value; });
return *this; return *this;