LibJS: Remove Object(Object& prototype) footgun

This constructor was easily confused with a copy constructor, and it was
possible to accidentally copy-construct Objects in at least one way that
we dicovered (via generic ThrowCompletionOr construction).

This patch adds a mandatory ConstructWithPrototypeTag parameter to the
constructor to disambiguate it.

Userland/Libraries/LibJS/Runtime/Intl/Collator.cpp

@@ -10,7 +10,7 @@ namespace JS::Intl {
 
 // 10 Collator Objects, https://tc39.es/ecma402/#collator-objects
 Collator::Collator(Object& prototype)
-    : Object(prototype)
+    : Object(ConstructWithPrototypeTag::Tag, prototype)
 {
 }
 

Userland/Libraries/LibJS/Runtime/Intl/DateTimeFormat.cpp

@@ -26,7 +26,7 @@ static Crypto::SignedBigInteger const s_one_million_bigint { 1'000'000 };
 
 // 11 DateTimeFormat Objects, https://tc39.es/ecma402/#datetimeformat-objects
 DateTimeFormat::DateTimeFormat(Object& prototype)
-    : Object(prototype)
+    : Object(ConstructWithPrototypeTag::Tag, prototype)
 {
 }
 

Userland/Libraries/LibJS/Runtime/Intl/DisplayNames.cpp

@@ -12,7 +12,7 @@ namespace JS::Intl {
 
 // 12 DisplayNames Objects, https://tc39.es/ecma402/#intl-displaynames-objects
 DisplayNames::DisplayNames(Object& prototype)
-    : Object(prototype)
+    : Object(ConstructWithPrototypeTag::Tag, prototype)
 {
 }
 

Userland/Libraries/LibJS/Runtime/Intl/DurationFormat.cpp

@@ -20,7 +20,7 @@ namespace JS::Intl {
 
 // 1 DurationFormat Objects, https://tc39.es/proposal-intl-duration-format/#durationformat-objects
 DurationFormat::DurationFormat(Object& prototype)
-    : Object(prototype)
+    : Object(ConstructWithPrototypeTag::Tag, prototype)
 {
 }
 

Userland/Libraries/LibJS/Runtime/Intl/Intl.cpp

@@ -28,7 +28,7 @@ namespace JS::Intl {
 
 // 8 The Intl Object, https://tc39.es/ecma402/#intl-object
 Intl::Intl(Realm& realm)
-    : Object(*realm.intrinsics().object_prototype())
+    : Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().object_prototype())
 {
 }
 

Userland/Libraries/LibJS/Runtime/Intl/ListFormat.cpp

@@ -14,7 +14,7 @@ namespace JS::Intl {
 
 // 13 ListFormat Objects, https://tc39.es/ecma402/#listformat-objects
 ListFormat::ListFormat(Object& prototype)
-    : Object(prototype)
+    : Object(ConstructWithPrototypeTag::Tag, prototype)
 {
 }
 

Userland/Libraries/LibJS/Runtime/Intl/Locale.cpp

@@ -21,12 +21,12 @@ NonnullGCPtr<Locale> Locale::create(Realm& realm, ::Locale::LocaleID const& loca
 
 // 14 Locale Objects, https://tc39.es/ecma402/#locale-objects
 Locale::Locale(Object& prototype)
-    : Object(prototype)
+    : Object(ConstructWithPrototypeTag::Tag, prototype)
 {
 }
 
 Locale::Locale(::Locale::LocaleID const& locale_id, Object& prototype)
-    : Object(prototype)
+    : Object(ConstructWithPrototypeTag::Tag, prototype)
 {
     set_locale(locale_id.to_deprecated_string());
 

Userland/Libraries/LibJS/Runtime/Intl/NumberFormat.cpp

@@ -21,7 +21,7 @@
 namespace JS::Intl {
 
 NumberFormatBase::NumberFormatBase(Object& prototype)
-    : Object(prototype)
+    : Object(ConstructWithPrototypeTag::Tag, prototype)
 {
 }
 

Userland/Libraries/LibJS/Runtime/Intl/RelativeTimeFormat.cpp

@@ -17,7 +17,7 @@ namespace JS::Intl {
 
 // 17 RelativeTimeFormat Objects, https://tc39.es/ecma402/#relativetimeformat-objects
 RelativeTimeFormat::RelativeTimeFormat(Object& prototype)
-    : Object(prototype)
+    : Object(ConstructWithPrototypeTag::Tag, prototype)
 {
 }
 

Userland/Libraries/LibJS/Runtime/Intl/SegmentIterator.cpp

@@ -24,7 +24,7 @@ NonnullGCPtr<SegmentIterator> SegmentIterator::create(Realm& realm, Segmenter& s
 
 // 18.6 Segment Iterator Objects, https://tc39.es/ecma402/#sec-segment-iterator-objects
 SegmentIterator::SegmentIterator(Realm& realm, Segmenter& segmenter, Utf16View const& string, Segments const& segments)
-    : Object(*realm.intrinsics().intl_segment_iterator_prototype())
+    : Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().intl_segment_iterator_prototype())
     , m_iterating_segmenter(segmenter)
     , m_iterated_string(string)
     , m_segments(segments)

Userland/Libraries/LibJS/Runtime/Intl/Segmenter.cpp

@@ -14,7 +14,7 @@ namespace JS::Intl {
 
 // 18 Segmenter Objects, https://tc39.es/ecma402/#segmenter-objects
 Segmenter::Segmenter(Object& prototype)
-    : Object(prototype)
+    : Object(ConstructWithPrototypeTag::Tag, prototype)
 {
 }
 

Userland/Libraries/LibJS/Runtime/Intl/Segments.cpp

@@ -23,7 +23,7 @@ NonnullGCPtr<Segments> Segments::create(Realm& realm, Segmenter& segmenter, Utf1
 
 // 18.5 Segments Objects, https://tc39.es/ecma402/#sec-segments-objects
 Segments::Segments(Realm& realm, Segmenter& segmenter, Utf16String string)
-    : Object(*realm.intrinsics().intl_segments_prototype())
+    : Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().intl_segments_prototype())
     , m_segments_segmenter(segmenter)
     , m_segments_string(move(string))
 {