mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 19:37:35 +00:00
LibJS: Remove Object(Object& prototype) footgun
This constructor was easily confused with a copy constructor, and it was possible to accidentally copy-construct Objects in at least one way that we dicovered (via generic ThrowCompletionOr construction). This patch adds a mandatory ConstructWithPrototypeTag parameter to the constructor to disambiguate it.
This commit is contained in:
parent
42b5c896e8
commit
4abdb68655
90 changed files with 100 additions and 99 deletions
|
@ -19,7 +19,7 @@ NonnullGCPtr<WeakRef> WeakRef::create(Realm& realm, Symbol& value)
|
|||
}
|
||||
|
||||
WeakRef::WeakRef(Object& value, Object& prototype)
|
||||
: Object(prototype)
|
||||
: Object(ConstructWithPrototypeTag::Tag, prototype)
|
||||
, WeakContainer(heap())
|
||||
, m_value(&value)
|
||||
, m_last_execution_generation(vm().execution_generation())
|
||||
|
@ -27,7 +27,7 @@ WeakRef::WeakRef(Object& value, Object& prototype)
|
|||
}
|
||||
|
||||
WeakRef::WeakRef(Symbol& value, Object& prototype)
|
||||
: Object(prototype)
|
||||
: Object(ConstructWithPrototypeTag::Tag, prototype)
|
||||
, WeakContainer(heap())
|
||||
, m_value(&value)
|
||||
, m_last_execution_generation(vm().execution_generation())
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue