RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 08:27:46 +00:00
Code Issues Activity Actions

LibJS: Remove Object(Object& prototype) footgun

Browse source 
This constructor was easily confused with a copy constructor, and it was
possible to accidentally copy-construct Objects in at least one way that
we dicovered (via generic ThrowCompletionOr construction).

This patch adds a mandatory ConstructWithPrototypeTag parameter to the
constructor to disambiguate it.
This commit is contained in:
Andreas Kling 2022-12-14 12:17:58 +01:00
parent 42b5c896e8
commit 4abdb68655
90 changed files with 100 additions and 99 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Bindings/CSSNamespace.cpp
View file

@ -14,7 +14,7 @@
namespace Web::Bindings {
CSSNamespace::CSSNamespace(JS::Realm& realm)
: JS::Object(*realm.intrinsics().object_prototype())
: JS::Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().object_prototype())
{
}

2
Userland/Libraries/LibWeb/Bindings/LocationPrototype.h
View file

@ -19,7 +19,7 @@ class LocationPrototype final : public JS::Object {
public:
explicit LocationPrototype(JS::Realm& realm)
: JS::Object(*realm.intrinsics().object_prototype())
: JS::Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().object_prototype())
{
}
};

2
Userland/Libraries/LibWeb/Bindings/PlatformObject.cpp
View file

@ -17,7 +17,7 @@ PlatformObject::PlatformObject(JS::Realm& realm)
}
PlatformObject::PlatformObject(JS::Object& prototype)
: JS::Object(prototype)
: JS::Object(ConstructWithPrototypeTag::Tag, prototype)
{
}

2
Userland/Libraries/LibWeb/Bindings/WindowPrototype.h
View file

@ -17,7 +17,7 @@ class WindowPrototype final : public JS::Object {
public:
explicit WindowPrototype(JS::Realm& realm)
: JS::Object(cached_web_prototype(realm, "EventTarget"))
: JS::Object(ConstructWithPrototypeTag::Tag, cached_web_prototype(realm, "EventTarget"))
{
}
};

2
Userland/Libraries/LibWeb/DOM/IDLEventListener.cpp
View file

@ -14,7 +14,7 @@ JS::NonnullGCPtr<IDLEventListener> IDLEventListener::create(JS::Realm& realm, JS
}
IDLEventListener::IDLEventListener(JS::Realm& realm, JS::NonnullGCPtr<WebIDL::CallbackType> callback)
: JS::Object(*realm.intrinsics().object_prototype())
: JS::Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().object_prototype())
, m_callback(move(callback))
{
}

2
Userland/Libraries/LibWeb/WebAssembly/WebAssemblyInstanceObject.cpp
View file

@ -19,7 +19,7 @@
namespace Web::Bindings {
WebAssemblyInstanceObject::WebAssemblyInstanceObject(JS::Realm& realm, size_t index)
: Object(Bindings::ensure_web_prototype<WebAssemblyInstancePrototype>(realm, "WebAssemblyInstancePrototype"))
: Object(ConstructWithPrototypeTag::Tag, Bindings::ensure_web_prototype<WebAssemblyInstancePrototype>(realm, "WebAssemblyInstancePrototype"))
, m_index(index)
{
}

2
Userland/Libraries/LibWeb/WebAssembly/WebAssemblyInstanceObjectPrototype.h
View file

@ -18,7 +18,7 @@ class WebAssemblyInstancePrototype final : public JS::Object {
public:
explicit WebAssemblyInstancePrototype(JS::Realm& realm)
: JS::Object(*realm.intrinsics().object_prototype())
: JS::Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().object_prototype())
{
}

2
Userland/Libraries/LibWeb/WebAssembly/WebAssemblyMemoryPrototype.h
View file

@ -18,7 +18,7 @@ class WebAssemblyMemoryPrototype final : public JS::Object {
public:
explicit WebAssemblyMemoryPrototype(JS::Realm& realm)
: JS::Object(*realm.intrinsics().object_prototype())
: JS::Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().object_prototype())
{
}

2
Userland/Libraries/LibWeb/WebAssembly/WebAssemblyModuleObject.cpp
View file

@ -11,7 +11,7 @@
namespace Web::Bindings {
WebAssemblyModuleObject::WebAssemblyModuleObject(JS::Realm& realm, size_t index)
: Object(Bindings::ensure_web_prototype<WebAssemblyModulePrototype>(realm, "WebAssemblyModulePrototype"))
: Object(ConstructWithPrototypeTag::Tag, Bindings::ensure_web_prototype<WebAssemblyModulePrototype>(realm, "WebAssemblyModulePrototype"))
, m_index(index)
{
}

2
Userland/Libraries/LibWeb/WebAssembly/WebAssemblyModulePrototype.h
View file

@ -18,7 +18,7 @@ class WebAssemblyModulePrototype final : public JS::Object {
public:
explicit WebAssemblyModulePrototype(JS::Realm& realm)
: JS::Object(*realm.intrinsics().object_prototype())
: JS::Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().object_prototype())
{
}
};

4
Userland/Libraries/LibWeb/WebAssembly/WebAssemblyObject.cpp
View file

@ -26,7 +26,7 @@
namespace Web::Bindings {
WebAssemblyObject::WebAssemblyObject(JS::Realm& realm)
: Object(*realm.intrinsics().object_prototype())
: Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().object_prototype())
{
s_abstract_machine.enable_instruction_count_limit();
}
@ -483,7 +483,7 @@ JS::NativeFunction* create_native_function(JS::VM& vm, Wasm::FunctionAddress add
}
WebAssemblyMemoryObject::WebAssemblyMemoryObject(JS::Realm& realm, Wasm::MemoryAddress address)
: Object(Bindings::ensure_web_prototype<WebAssemblyMemoryPrototype>(realm, "WebAssemblyMemoryPrototype"))
: Object(ConstructWithPrototypeTag::Tag, Bindings::ensure_web_prototype<WebAssemblyMemoryPrototype>(realm, "WebAssemblyMemoryPrototype"))
, m_address(address)
{
}

2
Userland/Libraries/LibWeb/WebAssembly/WebAssemblyTableObject.cpp
View file

@ -11,7 +11,7 @@
namespace Web::Bindings {
WebAssemblyTableObject::WebAssemblyTableObject(JS::Realm& realm, Wasm::TableAddress address)
: Object(Bindings::ensure_web_prototype<WebAssemblyTablePrototype>(realm, "WebAssemblyTablePrototype"))
: Object(ConstructWithPrototypeTag::Tag, Bindings::ensure_web_prototype<WebAssemblyTablePrototype>(realm, "WebAssemblyTablePrototype"))
, m_address(address)
{
}

2
Userland/Libraries/LibWeb/WebAssembly/WebAssemblyTablePrototype.h
View file

@ -18,7 +18,7 @@ class WebAssemblyTablePrototype final : public JS::Object {
public:
explicit WebAssemblyTablePrototype(JS::Realm& realm)
: JS::Object(*realm.intrinsics().object_prototype())
: JS::Object(ConstructWithPrototypeTag::Tag, *realm.intrinsics().object_prototype())
{
}