RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-10 03:47:34 +00:00
Code Issues Activity Actions

LibGUI: Add flag to TextDocument's word break locator methods

Browse source 
TextDocument::first_word_break_before was refactored out to be able
to be used in multiple places throughout the project. It turns out
that its behaviour needs to be slightly different depending on
where its called, so it now has a start_at_column_before flag
to decide which letter it "thinks" was clicked.
This commit is contained in:
FalseHonesty 2020-05-24 13:32:08 -04:00 • committed by Andreas Kling
parent 21b1aba03b
commit 4ad891a078
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibGUI/TextEditor.cpp
View file

@ -211,7 +211,7 @@ void TextEditor::doubleclick_event(MouseEvent& event)
auto end = start;
if (!document().has_spans()) {
start = document().first_word_break_before(start);
start = document().first_word_break_before(start, false);
end = document().first_word_break_after(end);
} else {
for (auto& span : document().spans()) {
@ -720,10 +720,10 @@ void TextEditor::keydown_event(KeyEvent& event)
new_cursor = span.value().range.start();
} else {
// No remaining spans, just use word break calculation
new_cursor = document().first_word_break_before(m_cursor);
new_cursor = document().first_word_break_before(m_cursor, true);
}
} else {
new_cursor = document().first_word_break_before(m_cursor);
new_cursor = document().first_word_break_before(m_cursor, true);
}
toggle_selection_if_needed_for_event(event);
set_cursor(new_cursor);