RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:47:46 +00:00
Code Issues Activity Actions

HexEditor: Remove redundant checks in offset_at()

Browse source 
Neither of these is possible based on the if statement above them.
This commit is contained in:
Sam Atkins 2024-02-05 16:00:57 +00:00 • committed by Sam Atkins
parent ca3f21f273
commit 4af565362c
1 changed files with 0 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/HexEditor/HexEditor.cpp
View file

@ -288,9 +288,6 @@ Optional<HexEditor::OffsetData> HexEditor::offset_at(Gfx::IntPoint position) con
// Hexadecimal display
if (absolute_x >= hex_start_x && absolute_x <= hex_end_x && absolute_y >= hex_start_y && absolute_y <= hex_end_y) {
if (absolute_x < hex_start_x || absolute_y < hex_start_y)
return {};
auto hex_text_start_x = hex_start_x + m_padding;
auto hex_text_end_x = hex_end_x - m_padding;
absolute_x = clamp(absolute_x, hex_text_start_x, hex_text_end_x);
@ -307,9 +304,6 @@ Optional<HexEditor::OffsetData> HexEditor::offset_at(Gfx::IntPoint position) con
// Text display
if (absolute_x >= text_start_x && absolute_x <= text_end_x && absolute_y >= text_start_y && absolute_y <= text_end_y) {
if (absolute_x < hex_start_x || absolute_y < hex_start_y)
return {};
auto text_text_start_x = text_start_x + m_padding;
auto text_text_end_x = text_end_x - m_padding;
absolute_x = clamp(absolute_x, text_text_start_x, text_text_end_x);