RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 23:27:43 +00:00
Code Issues Activity Actions

LibGUI+Userland: Use action text as a fallback in Action::status_tip()

Browse source 
Many applications already do this in their code. This change will simply
move the logic to a single function to stop repeating ourselves!
This commit is contained in:
Karol Kosek 2023-06-04 12:10:25 +02:00 • committed by Sam Atkins
parent 2029750519
commit 4b169cf25f
13 changed files with 21 additions and 48 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/Libraries/LibGUI/Action.cpp
View file

@ -11,6 +11,7 @@
#include <LibGUI/Button.h>
#include <LibGUI/MenuItem.h>
#include <LibGUI/Window.h>
#include <LibGfx/Painter.h>
namespace GUI {
@ -314,4 +315,12 @@ void Action::set_tooltip(DeprecatedString tooltip)
});
}
DeprecatedString Action::status_tip() const
{
if (!m_status_tip.is_empty())
return m_status_tip;
return Gfx::parse_ampersand_string(m_text);
}
}

2
Userland/Libraries/LibGUI/Action.h
View file

@ -88,7 +88,7 @@ public:
DeprecatedString tooltip() const { return m_tooltip.value_or(m_text); }
void set_tooltip(DeprecatedString);
DeprecatedString const& status_tip() const { return m_status_tip; }
DeprecatedString status_tip() const;
void set_status_tip(DeprecatedString status_tip) { m_status_tip = move(status_tip); }
Shortcut const& shortcut() const { return m_shortcut; }