From 4b3bc3805bb5bbed9ec56fa00d12f9038c716a1d Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Sat, 4 Sep 2021 12:46:19 +0200 Subject: [PATCH] Kernel: Add missing error check when opening root file system --- Kernel/Storage/StorageManagement.cpp | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/Kernel/Storage/StorageManagement.cpp b/Kernel/Storage/StorageManagement.cpp index 9b53b991e5..b00062bd84 100644 --- a/Kernel/Storage/StorageManagement.cpp +++ b/Kernel/Storage/StorageManagement.cpp @@ -182,11 +182,15 @@ NonnullRefPtr StorageManagement::root_filesystem() const if (!boot_device_description) { PANIC("StorageManagement: Couldn't find a suitable device to boot from"); } - auto e2fs = Ext2FS::create(FileDescription::try_create(boot_device_description.release_nonnull()).value()); - if (auto result = e2fs->initialize(); result.is_error()) { + auto description_or_error = FileDescription::try_create(boot_device_description.release_nonnull()); + VERIFY(!description_or_error.is_error()); + + auto file_system = Ext2FS::create(description_or_error.release_value()); + + if (auto result = file_system->initialize(); result.is_error()) { PANIC("StorageManagement: Couldn't open root filesystem: {}", result); } - return e2fs; + return file_system; } bool StorageManagement::initialized()