diff --git a/Kernel/API/KResult.h b/Kernel/API/KResult.h index 2ddf0f95d0..aa5334f76f 100644 --- a/Kernel/API/KResult.h +++ b/Kernel/API/KResult.h @@ -141,7 +141,7 @@ public: return m_error; } - [[nodiscard]] KResult result() const { return m_is_error ? m_error : KSuccess; } + KResult result() const { return m_is_error ? m_error : KSuccess; } [[nodiscard]] ALWAYS_INLINE T& value() & { @@ -167,7 +167,7 @@ public: return released_value; } - [[nodiscard]] KResult release_error() + KResult release_error() { VERIFY(m_is_error); return m_error; diff --git a/Kernel/Coredump.h b/Kernel/Coredump.h index 9a653219e9..11b7e65588 100644 --- a/Kernel/Coredump.h +++ b/Kernel/Coredump.h @@ -18,7 +18,7 @@ public: static KResultOr> try_create(NonnullRefPtr, StringView output_path); ~Coredump() = default; - [[nodiscard]] KResult write(); + KResult write(); private: Coredump(NonnullRefPtr, NonnullRefPtr); diff --git a/Kernel/Devices/AsyncDeviceRequest.h b/Kernel/Devices/AsyncDeviceRequest.h index ef0f86aa52..2afbce1838 100644 --- a/Kernel/Devices/AsyncDeviceRequest.h +++ b/Kernel/Devices/AsyncDeviceRequest.h @@ -90,7 +90,7 @@ public: } template - [[nodiscard]] KResultOr write_to_buffer_buffered(UserOrKernelBuffer& buffer, Args... args) + KResultOr write_to_buffer_buffered(UserOrKernelBuffer& buffer, Args... args) { if (in_target_context(buffer)) return buffer.write_buffered(forward(args)...); @@ -108,7 +108,7 @@ public: } template - [[nodiscard]] KResultOr read_from_buffer_buffered(const UserOrKernelBuffer& buffer, Args... args) + KResultOr read_from_buffer_buffered(const UserOrKernelBuffer& buffer, Args... args) { if (in_target_context(buffer)) return buffer.read_buffered(forward(args)...); diff --git a/Kernel/DoubleBuffer.h b/Kernel/DoubleBuffer.h index 0fd1899dc4..5e87b1afa3 100644 --- a/Kernel/DoubleBuffer.h +++ b/Kernel/DoubleBuffer.h @@ -17,19 +17,19 @@ namespace Kernel { class DoubleBuffer { public: [[nodiscard]] static OwnPtr try_create(size_t capacity = 65536); - [[nodiscard]] KResultOr write(const UserOrKernelBuffer&, size_t); - [[nodiscard]] KResultOr write(const u8* data, size_t size) + KResultOr write(const UserOrKernelBuffer&, size_t); + KResultOr write(const u8* data, size_t size) { return write(UserOrKernelBuffer::for_kernel_buffer(const_cast(data)), size); } - [[nodiscard]] KResultOr read(UserOrKernelBuffer&, size_t); - [[nodiscard]] KResultOr read(u8* data, size_t size) + KResultOr read(UserOrKernelBuffer&, size_t); + KResultOr read(u8* data, size_t size) { auto buffer = UserOrKernelBuffer::for_kernel_buffer(data); return read(buffer, size); } - [[nodiscard]] KResultOr peek(UserOrKernelBuffer&, size_t); - [[nodiscard]] KResultOr peek(u8* data, size_t size) + KResultOr peek(UserOrKernelBuffer&, size_t); + KResultOr peek(u8* data, size_t size) { auto buffer = UserOrKernelBuffer::for_kernel_buffer(data); return peek(buffer, size); diff --git a/Kernel/KString.h b/Kernel/KString.h index 2f157dfbec..0a06e5478b 100644 --- a/Kernel/KString.h +++ b/Kernel/KString.h @@ -23,7 +23,7 @@ public: void operator delete(void*); - [[nodiscard]] KResultOr> try_clone() const; + KResultOr> try_clone() const; [[nodiscard]] bool is_empty() const { return m_length == 0; } [[nodiscard]] size_t length() const { return m_length; } diff --git a/Kernel/StdLib.cpp b/Kernel/StdLib.cpp index 68f4baa142..edfe4bfc5a 100644 --- a/Kernel/StdLib.cpp +++ b/Kernel/StdLib.cpp @@ -193,7 +193,7 @@ KResult copy_from_user(void* dest_ptr, void const* src_ptr, size_t n) return KSuccess; } -[[nodiscard]] KResult memset_user(void* dest_ptr, int c, size_t n) +KResult memset_user(void* dest_ptr, int c, size_t n) { bool is_user = Kernel::Memory::is_user_range(VirtualAddress(dest_ptr), n); if (!is_user) diff --git a/Kernel/StdLib.h b/Kernel/StdLib.h index 65fc93aece..a2e1bbbb47 100644 --- a/Kernel/StdLib.h +++ b/Kernel/StdLib.h @@ -34,9 +34,9 @@ KResultOr