RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:47:45 +00:00
Code Issues Activity Actions

LibGfx: Use safe version of count_leading_zeroes() in WOFF parsers

Browse source 
This guards against undefined behavior when zero is given as an
argument.
This commit is contained in:
Tim Ledbetter 2023-10-26 23:47:08 +01:00 • committed by Andreas Kling
parent 88bd7d83ad
commit 4b5b8fc564
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGfx/Font/WOFF/Font.cpp
View file

@ -65,7 +65,7 @@ static u16 pow_2_less_than_or_equal(u16 x)
{ {
VERIFY(x > 0); VERIFY(x > 0);
VERIFY(x < 32769); VERIFY(x < 32769);
return 1 << (sizeof(u16) * 8 - count_leading_zeroes<u16>(x - 1)); return 1 << (sizeof(u16) * 8 - count_leading_zeroes_safe<u16>(x - 1));
} }
ErrorOr<NonnullRefPtr<Font>> Font::try_load_from_file(DeprecatedString path, unsigned int index) ErrorOr<NonnullRefPtr<Font>> Font::try_load_from_file(DeprecatedString path, unsigned int index)

2
Userland/Libraries/LibGfx/Font/WOFF2/Font.cpp
View file

@ -113,7 +113,7 @@ static u16 pow_2_less_than_or_equal(u16 x)
{ {
VERIFY(x > 0); VERIFY(x > 0);
VERIFY(x < 32769); VERIFY(x < 32769);
return 1 << (sizeof(u16) * 8 - count_leading_zeroes<u16>(x - 1)); return 1 << (sizeof(u16) * 8 - count_leading_zeroes_safe<u16>(x - 1));
} }
enum class TransformationVersion { enum class TransformationVersion {