From 4b6b9f272f83d5932e9dca771d54e6ab5252b758 Mon Sep 17 00:00:00 2001 From: Jelle Raaijmakers Date: Wed, 23 Mar 2022 10:28:39 +0100 Subject: [PATCH] LibGL: Use correct `GLbyte` range in `glColor4b` We were only setting half the color intensity that we should have set. --- Userland/Libraries/LibGL/GLColor.cpp | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibGL/GLColor.cpp b/Userland/Libraries/LibGL/GLColor.cpp index f1b68341a9..a3b50c3fc1 100644 --- a/Userland/Libraries/LibGL/GLColor.cpp +++ b/Userland/Libraries/LibGL/GLColor.cpp @@ -1,6 +1,7 @@ /* * Copyright (c) 2021, Jesse Buhagiar * Copyright (c) 2021, Stephan Unverwerth + * Copyright (c) 2022, Jelle Raaijmakers * * SPDX-License-Identifier: BSD-2-Clause */ @@ -42,7 +43,11 @@ void glColor3ubv(GLubyte const* v) void glColor4b(GLbyte r, GLbyte g, GLbyte b, GLbyte a) { - g_gl_context->gl_color(r / 255.0, g / 255.0, b / 255.0, a / 255.0); + g_gl_context->gl_color( + (static_cast(r) + 128) / 127.5 - 1, + (static_cast(g) + 128) / 127.5 - 1, + (static_cast(b) + 128) / 127.5 - 1, + (static_cast(a) + 128) / 127.5 - 1); } void glColor4dv(GLdouble const* v)