LibWeb: Split PercentageStyleValue out of StyleValue.{h,cpp}

Meta/Lagom/Tools/CodeGenerators/LibWeb/GenerateCSSPropertyID.cpp

@@ -155,6 +155,7 @@ ErrorOr<void> generate_implementation_file(JsonObject& properties, Core::File& f
 #include <LibWeb/CSS/Parser/Parser.h>
 #include <LibWeb/CSS/PropertyID.h>
 #include <LibWeb/CSS/StyleValue.h>
+#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
 #include <LibWeb/Infra/Strings.h>
 
 namespace Web::CSS {

Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp

@@ -58,6 +58,7 @@
 #include <LibWeb/CSS/StyleValues/ListStyleStyleValue.h>
 #include <LibWeb/CSS/StyleValues/NumericStyleValue.h>
 #include <LibWeb/CSS/StyleValues/OverflowStyleValue.h>
+#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
 #include <LibWeb/CSS/StyleValues/RadialGradientStyleValue.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/Dump.h>

Userland/Libraries/LibWeb/CSS/ResolvedCSSStyleDeclaration.cpp

@@ -26,6 +26,7 @@
 #include <LibWeb/CSS/StyleValues/InitialStyleValue.h>
 #include <LibWeb/CSS/StyleValues/LengthStyleValue.h>
 #include <LibWeb/CSS/StyleValues/NumericStyleValue.h>
+#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/DOM/Element.h>
 #include <LibWeb/Layout/Viewport.h>

Userland/Libraries/LibWeb/CSS/StyleComputer.cpp

@@ -42,6 +42,7 @@
 #include <LibWeb/CSS/StyleValues/ListStyleStyleValue.h>
 #include <LibWeb/CSS/StyleValues/NumericStyleValue.h>
 #include <LibWeb/CSS/StyleValues/OverflowStyleValue.h>
+#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/DOM/Element.h>
 #include <LibWeb/FontCache.h>

Userland/Libraries/LibWeb/CSS/StyleProperties.cpp

@@ -14,6 +14,7 @@
 #include <LibWeb/CSS/StyleValues/GridTemplateAreaStyleValue.h>
 #include <LibWeb/CSS/StyleValues/GridTrackPlacementStyleValue.h>
 #include <LibWeb/CSS/StyleValues/GridTrackSizeStyleValue.h>
+#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
 #include <LibWeb/FontCache.h>
 #include <LibWeb/Layout/BlockContainer.h>
 #include <LibWeb/Layout/Node.h>

Userland/Libraries/LibWeb/CSS/StyleValue.cpp

@@ -41,6 +41,7 @@
 #include <LibWeb/CSS/StyleValues/ListStyleStyleValue.h>
 #include <LibWeb/CSS/StyleValues/NumericStyleValue.h>
 #include <LibWeb/CSS/StyleValues/OverflowStyleValue.h>
+#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
 #include <LibWeb/CSS/StyleValues/RadialGradientStyleValue.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/HTML/BrowsingContext.h>
@@ -1138,11 +1139,6 @@ ErrorOr<void> PositionValue::serialize(StringBuilder& builder) const
     return {};
 }
 
-ErrorOr<String> PercentageStyleValue::to_string() const
-{
-    return m_percentage.to_string();
-}
-
 ErrorOr<String> PositionStyleValue::to_string() const
 {
     auto to_string = [](PositionEdge edge) {

Userland/Libraries/LibWeb/CSS/StyleValue.h

@@ -627,31 +627,6 @@ private:
     NonnullOwnPtr<CalcSum> m_expression;
 };
 
-class PercentageStyleValue final : public StyleValueWithDefaultOperators<PercentageStyleValue> {
-public:
-    static ValueComparingNonnullRefPtr<PercentageStyleValue> create(Percentage percentage)
-    {
-        return adopt_ref(*new PercentageStyleValue(move(percentage)));
-    }
-    virtual ~PercentageStyleValue() override = default;
-
-    Percentage const& percentage() const { return m_percentage; }
-    Percentage& percentage() { return m_percentage; }
-
-    virtual ErrorOr<String> to_string() const override;
-
-    bool properties_equal(PercentageStyleValue const& other) const { return m_percentage == other.m_percentage; }
-
-private:
-    PercentageStyleValue(Percentage&& percentage)
-        : StyleValueWithDefaultOperators(Type::Percentage)
-        , m_percentage(percentage)
-    {
-    }
-
-    Percentage m_percentage;
-};
-
 class PositionStyleValue final : public StyleValueWithDefaultOperators<PositionStyleValue> {
 public:
     static ValueComparingNonnullRefPtr<PositionStyleValue> create(PositionEdge edge_x, LengthPercentage const& offset_x, PositionEdge edge_y, LengthPercentage const& offset_y)

Userland/Libraries/LibWeb/CSS/StyleValues/PercentageStyleValue.h

@@ -0,0 +1,42 @@
+/*
+ * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2021, Tobias Christiansen <tobyase@serenityos.org>
+ * Copyright (c) 2021-2023, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022-2023, MacDue <macdue@dueutil.tech>
+ *
+ * SPDX-License-Identifier: BSD-2-Clause
+ */
+
+#pragma once
+
+#include <LibWeb/CSS/Percentage.h>
+#include <LibWeb/CSS/StyleValue.h>
+
+namespace Web::CSS {
+
+class PercentageStyleValue final : public StyleValueWithDefaultOperators<PercentageStyleValue> {
+public:
+    static ValueComparingNonnullRefPtr<PercentageStyleValue> create(Percentage percentage)
+    {
+        return adopt_ref(*new PercentageStyleValue(move(percentage)));
+    }
+    virtual ~PercentageStyleValue() override = default;
+
+    Percentage const& percentage() const { return m_percentage; }
+    Percentage& percentage() { return m_percentage; }
+
+    virtual ErrorOr<String> to_string() const override { return m_percentage.to_string(); }
+
+    bool properties_equal(PercentageStyleValue const& other) const { return m_percentage == other.m_percentage; }
+
+private:
+    PercentageStyleValue(Percentage&& percentage)
+        : StyleValueWithDefaultOperators(Type::Percentage)
+        , m_percentage(percentage)
+    {
+    }
+
+    Percentage m_percentage;
+};
+
+}

Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp

@@ -11,6 +11,7 @@
 #include <LibTextCodec/Decoder.h>
 #include <LibWeb/Bindings/MainThreadVM.h>
 #include <LibWeb/CSS/StyleValues/LengthStyleValue.h>
+#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
 #include <LibWeb/DOM/Comment.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/DOM/DocumentType.h>

Userland/Libraries/LibWeb/Layout/TreeBuilder.cpp

@@ -10,6 +10,7 @@
 #include <AK/Optional.h>
 #include <AK/TemporaryChange.h>
 #include <LibWeb/CSS/StyleValues/IdentifierStyleValue.h>
+#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/DOM/Element.h>
 #include <LibWeb/DOM/ParentNode.h>

Userland/Libraries/LibWeb/SVG/SVGSVGElement.cpp

@@ -7,6 +7,7 @@
 
 #include <LibWeb/CSS/Parser/Parser.h>
 #include <LibWeb/CSS/StyleComputer.h>
+#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
 #include <LibWeb/DOM/Document.h>
 #include <LibWeb/DOM/Event.h>
 #include <LibWeb/HTML/Parser/HTMLParser.h>