RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:07:45 +00:00
Code Issues Activity Actions

AK: Add fast path in String::trim() and String::trim_whitespace()

Browse source 
If the trimmed string would be the entire string, just return *this
instead of creating a new StringImpl.
This commit is contained in:
Andreas Kling 2022-02-19 00:36:30 +01:00
parent 25504f6a1b
commit 4b900bc100
1 changed files with 8 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

10
AK/String.h
View file

@ -127,12 +127,18 @@ public:
#ifndef KERNEL #ifndef KERNEL
[[nodiscard]] String trim(StringView characters, TrimMode mode = TrimMode::Both) const [[nodiscard]] String trim(StringView characters, TrimMode mode = TrimMode::Both) const
{ {
return StringUtils::trim(view(), characters, mode); auto trimmed_view = StringUtils::trim(view(), characters, mode);
if (view() == trimmed_view)
return *this;
return trimmed_view;
} }
[[nodiscard]] String trim_whitespace(TrimMode mode = TrimMode::Both) const [[nodiscard]] String trim_whitespace(TrimMode mode = TrimMode::Both) const
{ {
return StringUtils::trim_whitespace(view(), mode); auto trimmed_view = StringUtils::trim_whitespace(view(), mode);
if (view() == trimmed_view)
return *this;
return trimmed_view;
} }
#endif #endif