RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 01:07:35 +00:00
Code Issues Activity Actions

LibGUI: Store NumericInput value as an i64

Browse source 
Moar range = moar better. I'm hoping to use this for a size_t value
later, so this almost covers that.
This commit is contained in:
Sam Atkins 2024-01-08 17:32:33 +00:00 • committed by Sam Atkins
parent ea31c11aff
commit 4b96136803
3 changed files with 11 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/PDFViewer/PDFViewerWidget.cpp
View file

@ -281,7 +281,7 @@ void PDFViewerWidget::initialize_toolbar(GUI::Toolbar& toolbar)
m_page_text_box->set_fixed_width(30); m_page_text_box->set_fixed_width(30);
m_page_text_box->set_min_number(1); m_page_text_box->set_min_number(1);
m_page_text_box->on_number_changed = [&](i32 number) { m_page_text_box->on_number_changed = [&](i64 number) {
auto page_count = m_viewer->document()->get_page_count(); auto page_count = m_viewer->document()->get_page_count();
auto new_page_number = static_cast<u32>(number); auto new_page_number = static_cast<u32>(number);
VERIFY(new_page_number >= 1 && new_page_number <= page_count); VERIFY(new_page_number >= 1 && new_page_number <= page_count);

6
Userland/Libraries/LibGUI/NumericInput.cpp
View file

@ -55,14 +55,14 @@ NumericInput::NumericInput()
on_escape_pressed = [&] { on_focus_lost(); }; on_escape_pressed = [&] { on_focus_lost(); };
} }
void NumericInput::set_min_number(i32 number) void NumericInput::set_min_number(i64 number)
{ {
m_min_number = number; m_min_number = number;
if (m_current_number < number) if (m_current_number < number)
set_current_number(number); set_current_number(number);
} }
void NumericInput::set_max_number(i32 number) void NumericInput::set_max_number(i64 number)
{ {
m_max_number = number; m_max_number = number;
if (m_current_number > number) if (m_current_number > number)
@ -79,7 +79,7 @@ void NumericInput::on_focus_lost()
on_number_changed(m_current_number); on_number_changed(m_current_number);
} }
void NumericInput::set_current_number(i32 number, GUI::AllowCallback allow_callback) void NumericInput::set_current_number(i64 number, GUI::AllowCallback allow_callback)
{ {
if (number == m_current_number) if (number == m_current_number)
return; return;

14
Userland/Libraries/LibGUI/NumericInput.h
View file

@ -16,20 +16,20 @@ class NumericInput final : public GUI::TextBox {
public: public:
virtual ~NumericInput() override = default; virtual ~NumericInput() override = default;
Function<void(i32)> on_number_changed; Function<void(i64)> on_number_changed;
void set_min_number(i32 number); void set_min_number(i64 number);
void set_max_number(i32 number); void set_max_number(i64 number);
void set_current_number(i32 number, GUI::AllowCallback allow_callback = GUI::AllowCallback::Yes); void set_current_number(i64 number, GUI::AllowCallback allow_callback = GUI::AllowCallback::Yes);
private: private:
NumericInput(); NumericInput();
void on_focus_lost(); void on_focus_lost();
bool m_needs_text_reset { false }; bool m_needs_text_reset { false };
i32 m_current_number { 0 }; i64 m_current_number { 0 };
i32 m_min_number { NumericLimits<i32>::min() }; i64 m_min_number { NumericLimits<i64>::min() };
i32 m_max_number { NumericLimits<i32>::max() }; i64 m_max_number { NumericLimits<i64>::max() };
}; };
} }