RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:57:35 +00:00
Code Issues Activity Actions

chown: Don't allow "invalid" uid/gid specs (#2596)

Browse source 
The usage message states that a uid/gid spec should be <uid[:gid]>.

Let's not allow `anon:`, `anon:users:hello` and `:users` then.
This commit is contained in:
Emanuele Torre 2020-06-21 09:54:07 +02:00 • committed by GitHub
parent 8edecbea4b
commit 4bbe01def1
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/chown.cpp
View file

@ -48,11 +48,15 @@ int main(int argc, char** argv)
uid_t new_uid = -1; uid_t new_uid = -1;
gid_t new_gid = -1; gid_t new_gid = -1;
auto parts = String(argv[1]).split(':'); auto parts = String(argv[1]).split(':', true);
if (parts.is_empty()) { if (parts.is_empty()) {
fprintf(stderr, "Empty uid/gid spec\n"); fprintf(stderr, "Empty uid/gid spec\n");
return 1; return 1;
} }
if (parts[0].is_empty() || (parts.size() == 2 && parts[1].is_empty()) || parts.size() > 2) {
fprintf(stderr, "Invalid uid/gid spec\n");
return 1;
}
auto number = parts[0].to_uint(); auto number = parts[0].to_uint();
if (number.has_value()) { if (number.has_value()) {