RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 21:17:45 +00:00
Code Issues Activity Actions

Kernel: Make Region's physical page accessors safer to use

Browse source 
Region::physical_page() now takes the VMObject lock while accessing the
physical pages array, and returns a RefPtr<PhysicalPage>. This ensures
that the array access is safe.

Region::physical_page_slot() now VERIFY()'s that the VMObject lock is
held by the caller. Since we're returning a reference to the physical
page slot in the VMObject's physical page array, this is the best we
can do here.
This commit is contained in:
Andreas Kling 2022-08-18 19:20:33 +02:00
parent c3ad4ffcec
commit 4bc3745ce6
4 changed files with 12 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Memory/Region.h
View file

@ -152,7 +152,7 @@ public:
return size() / PAGE_SIZE;
}
PhysicalPage const* physical_page(size_t index) const;
RefPtr<PhysicalPage> physical_page(size_t index) const;
RefPtr<PhysicalPage>& physical_page_slot(size_t index);
[[nodiscard]] size_t offset_in_vmobject() const