RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:17:44 +00:00
Code Issues Activity Actions

LibRegex: Make parse_disjunction() consume all disjunctions in one frame

Browse source 
This helps us not blow up when too many disjunctions are chained togther
in the regex we're parsing.
Fixes #12615.
This commit is contained in:
Ali Mohammad Pur 2022-02-19 17:34:55 +03:30 • committed by Andreas Kling
parent 627bbee055
commit 4be7239626
2 changed files with 33 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Tests/LibRegex/Regex.cpp
View file

@ -498,6 +498,8 @@ TEST_CASE(posix_extended_nested_capture_group)
EXPECT_EQ(result.capture_group_matches[0][2].view, "llo"sv);
}
auto parse_test_case_long_disjunction_chain = String::repeated("a|"sv, 10000);
TEST_CASE(ECMA262_parse)
{
struct _test {
@ -506,7 +508,7 @@ TEST_CASE(ECMA262_parse)
regex::ECMAScriptFlags flags {};
};
constexpr _test tests[] {
_test const tests[] {
{ "^hello.$"sv },
{ "^(hello.)$"sv },
{ "^h{0,1}ello.$"sv },
@ -599,7 +601,8 @@ TEST_CASE(ECMA262_parse)
{ "(?<$$_$$>a)"sv },
{ "(?<ÿ>a)"sv },
{ "(?<𝓑𝓻𝓸𝔀𝓷>a)"sv },
{ "((?=lg)?[vl]k\\-?\\d{3}) bui| 3\\.[-\\w; ]{10}lg?-([06cv9]{3,4})"sv, regex::Error::NoError, ECMAScriptFlags::BrowserExtended } // #12373, quantifiable assertions.
{ "((?=lg)?[vl]k\\-?\\d{3}) bui| 3\\.[-\\w; ]{10}lg?-([06cv9]{3,4})"sv, regex::Error::NoError, ECMAScriptFlags::BrowserExtended }, // #12373, quantifiable assertions.
{ parse_test_case_long_disjunction_chain.view() }, // A whole lot of disjunctions, should not overflow the stack.
};
for (auto& test : tests) {