RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 04:58:13 +00:00
Code Issues Activity Actions

Help: Always show the welcome page on launch if nothing else is there

Browse source 
Previously, launching Help with a query like `Help tar` left the page
blank, which looks like something has gone wrong. Instead, let's show
the usual welcome page.
This commit is contained in:
Sam Atkins 2021-12-19 15:40:38 +00:00 • committed by Brian Gianforcaro
parent 3b71e7b5ee
commit 4bf2ef2a4c
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/Help/main.cpp
View file

@ -274,12 +274,14 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
context_menu->popup(screen_position);
};
bool set_start_page = false;
if (start_page) {
URL url = URL::create_with_url_or_path(start_page);
if (url.is_valid() && url.path().ends_with(".md")) {
history.push(url.path());
update_actions();
open_page(url.path());
set_start_page = true;
} else {
left_tab_bar->set_active_widget(search_view);
search_box->set_text(start_page);
@ -288,9 +290,9 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
search_model.set_filter_term(search_box->text());
}
}
} else {
go_home_action->activate();
}
if (!set_start_page)
go_home_action->activate();
auto statusbar = TRY(widget->try_add<GUI::Statusbar>());
app->on_action_enter = [&statusbar](GUI::Action const& action) {