RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 11:08:11 +00:00
Code Issues Activity Actions

LibRegex: Replace the checkpoint backing store with a Vector

Browse source 
This makes repeated lookups and insertions much faster, yielding a
general performance improvement of about 10% in the regex test suite.
This commit is contained in:
Ali Mohammad Pur 2023-07-14 09:18:32 +03:30 • committed by Andreas Kling
parent 2d6f50932b
commit 4bff4219ff
2 changed files with 8 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibRegex/RegexByteCode.cpp
View file

@ -1064,16 +1064,20 @@ ALWAYS_INLINE ExecutionResult OpCode_ResetRepeat::execute(MatchInput const&, Mat
ALWAYS_INLINE ExecutionResult OpCode_Checkpoint::execute(MatchInput const& input, MatchState& state) const
{
input.checkpoints.set(id(), state.string_position);
auto id = this->id();
if (id >= input.checkpoints.size())
input.checkpoints.resize(id + 1);
input.checkpoints[id] = state.string_position + 1;
return ExecutionResult::Continue;
}
ALWAYS_INLINE ExecutionResult OpCode_JumpNonEmpty::execute(MatchInput const& input, MatchState& state) const
{
u64 current_position = state.string_position;
auto checkpoint_position = input.checkpoints.find(checkpoint());
auto checkpoint_position = input.checkpoints[checkpoint()];
if (checkpoint_position != input.checkpoints.end() && checkpoint_position->value != current_position) {
if (checkpoint_position != 0 && checkpoint_position != current_position + 1) {
auto form = this->form();
if (form == OpCodeId::Jump) {