RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:58:12 +00:00
Code Issues Activity Actions

Kernel: Don't create a zero-length VLA in Ext2FS block list walk

Browse source 
Found by KUBSAN :^)
This commit is contained in:
Andreas Kling 2021-02-05 20:03:49 +01:00
parent d164f89ada
commit 4c0707e56c
1 changed files with 2 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/FileSystem/Ext2FileSystem.cpp
View file

@ -501,6 +501,8 @@ Vector<Ext2FS::BlockIndex> Ext2FS::block_list_for_inode_impl(const ext2_inode& e
if (include_block_list_blocks) if (include_block_list_blocks)
add_block(array_block_index); add_block(array_block_index);
auto count = min(blocks_remaining, entries_per_block); auto count = min(blocks_remaining, entries_per_block);
if (!count)
return;
u32 array[count]; u32 array[count];
auto buffer = UserOrKernelBuffer::for_kernel_buffer((u8*)array); auto buffer = UserOrKernelBuffer::for_kernel_buffer((u8*)array);
auto result = read_block(array_block_index, &buffer, sizeof(array), 0); auto result = read_block(array_block_index, &buffer, sizeof(array), 0);