From 4c5b9fa6a237aa278d0ad963feb4d885d5500a98 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Tue, 26 Sep 2023 09:36:28 +0200 Subject: [PATCH] LibJS: Remove unused SetVariable::InitializationMode::InitializeOrSet --- Userland/Libraries/LibJS/Bytecode/Op.cpp | 9 +-------- Userland/Libraries/LibJS/Bytecode/Op.h | 1 - 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/Userland/Libraries/LibJS/Bytecode/Op.cpp b/Userland/Libraries/LibJS/Bytecode/Op.cpp index cdbf0f7113..903201d33a 100644 --- a/Userland/Libraries/LibJS/Bytecode/Op.cpp +++ b/Userland/Libraries/LibJS/Bytecode/Op.cpp @@ -599,11 +599,6 @@ ThrowCompletionOr SetVariable::execute_impl(Bytecode::Interpreter& interpr case InitializationMode::Set: TRY(reference.put_value(vm, interpreter.accumulator())); break; - case InitializationMode::InitializeOrSet: - VERIFY(reference.is_environment_reference()); - VERIFY(reference.base_environment().is_declarative_environment()); - TRY(static_cast(reference.base_environment()).initialize_or_set_mutable_binding(vm, name, interpreter.accumulator())); - break; } return {}; } @@ -1581,9 +1576,7 @@ DeprecatedString EnterObjectEnvironment::to_deprecated_string_impl(Executable co DeprecatedString SetVariable::to_deprecated_string_impl(Bytecode::Executable const& executable) const { - auto initialization_mode_name = m_initialization_mode == InitializationMode ::Initialize ? "Initialize" - : m_initialization_mode == InitializationMode::Set ? "Set" - : "InitializeOrSet"; + auto initialization_mode_name = m_initialization_mode == InitializationMode::Initialize ? "Initialize" : "Set"; auto mode_string = m_mode == EnvironmentMode::Lexical ? "Lexical" : "Variable"; return DeprecatedString::formatted("SetVariable env:{} init:{} {} ({})", mode_string, initialization_mode_name, m_identifier, executable.identifier_table->get(m_identifier)); } diff --git a/Userland/Libraries/LibJS/Bytecode/Op.h b/Userland/Libraries/LibJS/Bytecode/Op.h index 32802fcdf1..78885aee61 100644 --- a/Userland/Libraries/LibJS/Bytecode/Op.h +++ b/Userland/Libraries/LibJS/Bytecode/Op.h @@ -408,7 +408,6 @@ public: enum class InitializationMode { Initialize, Set, - InitializeOrSet, }; explicit SetVariable(IdentifierTableIndex identifier, InitializationMode initialization_mode = InitializationMode::Set, EnvironmentMode mode = EnvironmentMode::Lexical) : Instruction(Type::SetVariable, sizeof(*this))