RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:57:46 +00:00
Code Issues Activity Actions

WindowServer: Fix a handful of clang-tidy warnings in the menu code

Browse source 
Some avoidable signed/unsigned mismatch, String move construction,
and functions that can be static constexpr.
This commit is contained in:
Andreas Kling 2021-05-09 11:09:58 +02:00
parent cbb06d7014
commit 4c6e3d0c59
4 changed files with 17 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/WindowServer/MenuItem.h
View file

@ -42,10 +42,10 @@ public:
void set_default(bool);
String text() const { return m_text; }
void set_text(const String& text) { m_text = text; }
void set_text(String text) { m_text = move(text); }
String shortcut_text() const { return m_shortcut_text; }
void set_shortcut_text(const String& text) { m_shortcut_text = text; }
void set_shortcut_text(String text) { m_shortcut_text = move(text); }
void set_rect(const Gfx::IntRect& rect) { m_rect = rect; }
Gfx::IntRect rect() const;