RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:07:35 +00:00
Code Issues Activity Actions

WindowServer: Fix a handful of clang-tidy warnings in the menu code

Browse source 
Some avoidable signed/unsigned mismatch, String move construction,
and functions that can be static constexpr.
This commit is contained in:
Andreas Kling 2021-05-09 11:09:58 +02:00
parent cbb06d7014
commit 4c6e3d0c59
4 changed files with 17 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/WindowServer/MenuManager.cpp
View file

@ -255,7 +255,7 @@ void MenuManager::close_menus(const Vector<Menu*>& menus)
static void collect_menu_subtree(Menu& menu, Vector<Menu*>& menus)
{
menus.append(&menu);
for (int i = 0; i < menu.item_count(); ++i) {
for (size_t i = 0; i < menu.item_count(); ++i) {
auto& item = menu.item(i);
if (!item.is_submenu())
continue;