RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:17:44 +00:00
Code Issues Activity Actions

LibWeb: Do not clear stream algorithms (and add corresponding FIXMEs)

Browse source
This commit is contained in:
Matthew Olsson 2023-04-24 18:48:35 -07:00 • committed by Andreas Kling
parent dd65d60069
commit 4c8015c1f6
1 changed files with 24 additions and 9 deletions
Download patch file Download diff file Expand all files Collapse all files

33
Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp
View file

@ -612,14 +612,19 @@ bool readable_stream_default_controller_should_call_pull(ReadableStreamDefaultCo
// https://streams.spec.whatwg.org/#readable-stream-default-controller-clear-algorithms // https://streams.spec.whatwg.org/#readable-stream-default-controller-clear-algorithms
void readable_stream_default_controller_clear_algorithms(ReadableStreamDefaultController& controller) void readable_stream_default_controller_clear_algorithms(ReadableStreamDefaultController& controller)
{ {
// FIXME: This AO can be invoked from within one of the algorithms below. If we clear them, it invokes SafeFunction's
// destructor, which asserts we are not currently invoking the function (as it clears the storage). We need to
// figure out how to delay this, as these algorithms may keep objects alive that can otherwise be GC'd.
(void)controller;
// 1. Set controller.[[pullAlgorithm]] to undefined. // 1. Set controller.[[pullAlgorithm]] to undefined.
controller.set_pull_algorithm({}); // controller.set_pull_algorithm({});
// 2. Set controller.[[cancelAlgorithm]] to undefined. // 2. Set controller.[[cancelAlgorithm]] to undefined.
controller.set_cancel_algorithm({}); // controller.set_cancel_algorithm({});
// 3. Set controller.[[strategySizeAlgorithm]] to undefined. // 3. Set controller.[[strategySizeAlgorithm]] to undefined.
controller.set_strategy_size_algorithm({}); // controller.set_strategy_size_algorithm({});
} }
// https://streams.spec.whatwg.org/#readable-stream-default-controller-error // https://streams.spec.whatwg.org/#readable-stream-default-controller-error
@ -847,11 +852,16 @@ WebIDL::ExceptionOr<void> readable_byte_stream_controller_call_pull_if_needed(Re
// https://streams.spec.whatwg.org/#readable-byte-stream-controller-clear-algorithms // https://streams.spec.whatwg.org/#readable-byte-stream-controller-clear-algorithms
void readable_byte_stream_controller_clear_algorithms(ReadableByteStreamController& controller) void readable_byte_stream_controller_clear_algorithms(ReadableByteStreamController& controller)
{ {
// FIXME: This AO can be invoked from within one of the algorithms below. If we clear them, it invokes SafeFunction's
// destructor, which asserts we are not currently invoking the function (as it clears the storage). We need to
// figure out how to delay this, as these algorithms may keep objects alive that can otherwise be GC'd.
(void)controller;
// 1. Set controller.[[pullAlgorithm]] to undefined. // 1. Set controller.[[pullAlgorithm]] to undefined.
controller.set_pull_algorithm({}); // controller.set_pull_algorithm({});
// 2. Set controller.[[cancelAlgorithm]] to undefined. // 2. Set controller.[[cancelAlgorithm]] to undefined.
controller.set_cancel_algorithm({}); // controller.set_cancel_algorithm({});
} }
// https://streams.spec.whatwg.org/#readable-byte-stream-controller-clear-pending-pull-intos // https://streams.spec.whatwg.org/#readable-byte-stream-controller-clear-pending-pull-intos
@ -2023,17 +2033,22 @@ WebIDL::ExceptionOr<void> writable_stream_default_controller_advance_queue_if_ne
// https://streams.spec.whatwg.org/#writable-stream-default-controller-clear-algorithms // https://streams.spec.whatwg.org/#writable-stream-default-controller-clear-algorithms
void writable_stream_default_controller_clear_algorithms(WritableStreamDefaultController& controller) void writable_stream_default_controller_clear_algorithms(WritableStreamDefaultController& controller)
{ {
// FIXME: This AO can be invoked from within one of the algorithms below. If we clear them, it invokes SafeFunction's
// destructor, which asserts we are not currently invoking the function (as it clears the storage). We need to
// figure out how to delay this, as these algorithms may keep objects alive that can otherwise be GC'd.
(void)controller;
// 1. Set controller.[[writeAlgorithm]] to undefined. // 1. Set controller.[[writeAlgorithm]] to undefined.
controller.set_write_algorithm({}); // controller.set_write_algorithm({});
// 2. Set controller.[[closeAlgorithm]] to undefined. // 2. Set controller.[[closeAlgorithm]] to undefined.
controller.set_close_algorithm({}); // controller.set_close_algorithm({});
// 3. Set controller.[[abortAlgorithm]] to undefined. // 3. Set controller.[[abortAlgorithm]] to undefined.
controller.set_abort_algorithm({}); // controller.set_abort_algorithm({});
// 4. Set controller.[[strategySizeAlgorithm]] to undefined. // 4. Set controller.[[strategySizeAlgorithm]] to undefined.
controller.set_strategy_size_algorithm({}); // controller.set_strategy_size_algorithm({});
} }
// https://streams.spec.whatwg.org/#writable-stream-default-controller-close // https://streams.spec.whatwg.org/#writable-stream-default-controller-close