RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 14:37:45 +00:00
Code Issues Activity Actions

LibJS: Implement ECMA-402 Date.prototype.toLocaleDateString

Browse source
This commit is contained in:
Timothy Flynn 2021-12-09 22:54:43 -05:00 • committed by Linus Groh
parent 9a62c01ebc
commit 4d310fd7aa
2 changed files with 75 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

24
Userland/Libraries/LibJS/Runtime/DatePrototype.cpp
View file

@ -681,17 +681,29 @@ static ThrowCompletionOr<Intl::DateTimeFormat*> construct_date_time_format(Globa
return static_cast<Intl::DateTimeFormat*>(date_time_format);
}
// 21.4.4.38 Date.prototype.toLocaleDateString ( [ reserved1 [ , reserved2 ] ] ), https://tc39.es/ecma262/#sec-date.prototype.tolocaledatestring
// 18.4.2 Date.prototype.toLocaleDateString ( [ locales [ , options ] ] ), https://tc39.es/ecma402/#sup-date.prototype.tolocaledatestring
JS_DEFINE_NATIVE_FUNCTION(DatePrototype::to_locale_date_string)
{
auto locales = vm.argument(0);
auto options = vm.argument(1);
// 1. Let x be ? thisTimeValue(this value).
auto* this_object = TRY(typed_this_object(global_object));
auto time = this_object->is_invalid() ? js_nan() : this_object->value_of();
if (this_object->is_invalid())
return js_string(vm, "Invalid Date");
// 2. If x is NaN, return "Invalid Date".
if (time.is_nan())
return js_string(vm, "Invalid Date"sv);
// FIXME: Optional locales, options params.
auto string = this_object->locale_date_string();
return js_string(vm, move(string));
// 3. Let options be ? ToDateTimeOptions(options, "date", "date").
options = Value(TRY(Intl::to_date_time_options(global_object, options, Intl::OptionRequired::Date, Intl::OptionDefaults::Date)));
// 4. Let dateFormat be ? Construct(%DateTimeFormat%, « locales, options »).
auto* date_format = TRY(construct_date_time_format(global_object, locales, options));
// 5. Return ? FormatDateTime(dateFormat, x).
auto formatted = TRY(Intl::format_date_time(global_object, *date_format, time));
return js_string(vm, move(formatted));
}
// 18.4.1 Date.prototype.toLocaleString ( [ locales [ , options ] ] ), https://tc39.es/ecma402/#sup-date.prototype.tolocalestring