RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 01:37:35 +00:00
Code Issues Activity Actions

LibJS: Expose TypedArray.prototype.byteOffset

Browse source
This commit is contained in:
Luke 2021-05-21 21:45:47 +01:00 • committed by Linus Groh
parent 58afd71ad2
commit 4d34802f74
4 changed files with 43 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/Libraries/LibJS/Runtime/CommonPropertyNames.h
View file

@ -59,6 +59,7 @@ namespace JS {
P(bind) \
P(buffer) \
P(byteLength) \
P(byteOffset) \
P(call) \
P(callee) \
P(cbrt) \

17
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.cpp
View file

@ -24,11 +24,8 @@ void TypedArrayPrototype::initialize(GlobalObject& object)
// FIXME: This should be an accessor property
define_native_property(vm.names.length, length_getter, nullptr, Attribute::Configurable);
define_native_property(vm.names.buffer, buffer_getter, nullptr, Attribute::Configurable);
<<<<<<< HEAD
=======
define_native_property(vm.names.byteLength, byte_length_getter, nullptr, Attribute::Configurable);
define_native_property(vm.names.BYTES_PER_ELEMENT, bytes_per_element_getter, nullptr, 0); // FIXME: This should just be a normal property and not a getter.
>>>>>>> 6be44bc62... LibJS: Expose TypedArray.prototype.byteLength
define_native_property(vm.names.byteOffset, byte_offset_getter, nullptr, Attribute::Configurable);
define_native_function(vm.names.at, at, 1, attr);
}
@ -102,4 +99,16 @@ JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::byte_length_getter)
return Value(typed_array->byte_length());
}
// https://tc39.es/ecma262/#sec-get-%typedarray%.prototype.byteoffset
JS_DEFINE_NATIVE_FUNCTION(TypedArrayPrototype::byte_offset_getter)
{
auto typed_array = typed_array_from(vm, global_object);
if (!typed_array)
return {};
auto* array_buffer = typed_array->viewed_array_buffer();
VERIFY(array_buffer);
// FIXME: If array_buffer is detached, return 0.
return Value(typed_array->byte_offset());
}
}

1
Userland/Libraries/LibJS/Runtime/TypedArrayPrototype.h
View file

@ -22,6 +22,7 @@ private:
JS_DECLARE_NATIVE_GETTER(length_getter);
JS_DECLARE_NATIVE_GETTER(buffer_getter);
JS_DECLARE_NATIVE_GETTER(byte_length_getter);
JS_DECLARE_NATIVE_GETTER(byte_offset_getter);
JS_DECLARE_NATIVE_FUNCTION(at);
};