RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:17:44 +00:00
Code Issues Activity Actions

LibWebView: Create a PropertyTableModel helper class for table models

Browse source 
We currently have StylePropertiesModel and AriaPropertiesStateModel in
LibWebView. These depend on GUI::Model and GUI::ModelIndex, which is the
only reason that the non-Serenity Ladybird chromes require LibGUI.
Further, these classes are very nearly idenitical.

This creates a PropertyTableModel to provide the base functionality for
all table-based model types used by all Ladybird chromes. It contains
code common to the style / ARIA table models, and handles the slight
differences between the two (namely, just the manner in which the values
are flattened into a list during construction).

The Qt and Serenity chromes can create thin wrappers around this class
to adapt its interface to their chrome-specific model classes (i.e.
QAbstractItemModel and GUI::Model).
This commit is contained in:
Timothy Flynn 2023-11-04 14:05:25 -04:00 • committed by Andreas Kling
parent 3999c74237
commit 4d356cfca5
3 changed files with 145 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

60
Userland/Libraries/LibWebView/PropertyTableModel.h Normal file
View file

@ -0,0 +1,60 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2023, Jonah Shafran <jonahshafran@gmail.com>
* Copyright (c) 2023, Tim Flynn <trflynn89@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
#pragma once
#include <AK/IterationDecision.h>
#include <AK/String.h>
#include <AK/Vector.h>
#include <LibWebView/ModelIndex.h>
namespace WebView {
class PropertyTableModel {
public:
enum class Type {
ARIAProperties,
StyleProperties,
};
enum class Column : int {
PropertyName,
PropertyValue,
};
PropertyTableModel(Type, JsonValue const&);
~PropertyTableModel();
template<typename Callback>
void for_each_property_name(Callback&& callback)
{
for (size_t i = 0; i < m_values.size(); ++i) {
ModelIndex index { static_cast<int>(i), to_underlying(WebView::PropertyTableModel::Column::PropertyName) };
auto const& property_name = m_values[i].name;
if (callback(index, property_name) == IterationDecision::Break)
break;
}
}
int row_count(ModelIndex const& parent) const;
int column_count(ModelIndex const& parent) const;
ErrorOr<String> column_name(int) const;
ModelIndex index(int row, int column, ModelIndex const& parent) const;
String text_for_display(ModelIndex const& index) const;
private:
struct Value {
String name;
String value;
};
Vector<Value> m_values;
};
}