RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:38:10 +00:00
Code Issues Activity Actions

LibHTML: Add Document::get_element_by_id() and get_elements_by_name()

Browse source 
These will be useful for implementing various things. They don't do any
caching at the moment, but that might become valuable in the future.

To facilitate this change, I also made it possible to abort a tree walk
with for_each_in_subtree() by returning IterationDecision::Break from
the callback.
This commit is contained in:
Andreas Kling 2019-10-21 12:01:30 +02:00
parent 465a33443c
commit 4d9740ecef
5 changed files with 57 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

28
Libraries/LibHTML/DOM/Document.cpp
View file

@ -193,9 +193,9 @@ void Document::layout()
void Document::update_style()
{
for_each_in_subtree([&](Node& node) {
if (!node.needs_style_update())
return;
if (node.needs_style_update())
to<Element>(node).recompute_style();
return IterationDecision::Continue;
});
update_layout();
}
@ -242,3 +242,27 @@ void Document::set_hovered_node(Node* node)
invalidate_style();
}
const Element* Document::get_element_by_id(const String& id) const
{
const Element* element = nullptr;
for_each_in_subtree([&](auto& node) {
if (is<Element>(node) && to<Element>(node).attribute("id") == id) {
element = &to<Element>(node);
return IterationDecision::Break;
}
return IterationDecision::Continue;
});
return element;
}
Vector<const Element*> Document::get_elements_by_name(const String& name) const
{
Vector<const Element*> elements;
for_each_in_subtree([&](auto& node) {
if (is<Element>(node) && to<Element>(node).attribute("name") == name)
elements.append(&to<Element>(node));
return IterationDecision::Continue;
});
return elements;
}

3
Libraries/LibHTML/DOM/Document.h
View file

@ -80,6 +80,9 @@ public:
void schedule_style_update();
const Element* get_element_by_id(const String&) const;
Vector<const Element*> get_elements_by_name(const String&) const;
private:
virtual RefPtr<LayoutNode> create_layout_node(const StyleProperties* parent_style) const override;

1
Libraries/LibHTML/DOM/Node.cpp
View file

@ -77,6 +77,7 @@ void Node::invalidate_style()
for_each_in_subtree([&](auto& node) {
if (is<Element>(node))
node.set_needs_style_update(true);
return IterationDecision::Continue;
});
document().schedule_style_update();
}

9
Libraries/LibHTML/HtmlView.cpp
View file

@ -321,11 +321,14 @@ void HtmlView::scroll_to_anchor(const StringView& name)
HTMLAnchorElement* element = nullptr;
document()->for_each_in_subtree([&](auto& node) {
if (!is<HTMLAnchorElement>(node))
return;
if (is<HTMLAnchorElement>(node)) {
auto& anchor_element = to<HTMLAnchorElement>(node);
if (anchor_element.name() == name)
if (anchor_element.name() == name) {
element = &anchor_element;
return IterationDecision::Break;
}
}
return IterationDecision::Continue;
});
if (!element) {

21
Libraries/LibHTML/TreeNode.h
View file

@ -54,12 +54,27 @@ public:
bool is_child_allowed(const T&) const { return true; }
template<typename Callback>
void for_each_in_subtree(Callback callback)
IterationDecision for_each_in_subtree(Callback callback) const
{
callback(static_cast<T&>(*this));
if (callback(static_cast<const T&>(*this)) == IterationDecision::Break)
return IterationDecision::Break;
for (auto* child = first_child(); child; child = child->next_sibling()) {
child->for_each_in_subtree(callback);
if (child->for_each_in_subtree(callback) == IterationDecision::Break)
return IterationDecision::Break;
}
return IterationDecision::Continue;
}
template<typename Callback>
IterationDecision for_each_in_subtree(Callback callback)
{
if (callback(static_cast<T&>(*this)) == IterationDecision::Break)
return IterationDecision::Break;
for (auto* child = first_child(); child; child = child->next_sibling()) {
if (child->for_each_in_subtree(callback) == IterationDecision::Break)
return IterationDecision::Break;
}
return IterationDecision::Continue;
}
protected: