RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:17:35 +00:00
Code Issues Activity Actions

LibWeb: Recurse into block-level children when hit testing a box

Browse source 
Otherwise, we always say you hit the parent, even when you're really
clicking on a child that's visually above the parent.
This commit is contained in:
Andreas Kling 2022-11-03 18:43:20 +01:00
parent 5aeb6fec68
commit 4de3449ad6
1 changed files with 12 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -649,9 +649,18 @@ Optional<HitTestResult> PaintableBox::hit_test(Gfx::FloatPoint const& position,
return stacking_context()->hit_test(position, type); return stacking_context()->hit_test(position, type);
} }
if (absolute_border_box_rect().contains(position.x(), position.y())) if (!absolute_border_box_rect().contains(position.x(), position.y()))
return HitTestResult { *this }; return {};
return {};
for (auto* child = first_child(); child; child = child->next_sibling()) {
auto result = child->hit_test(position, type);
if (!result.has_value())
continue;
if (!result->paintable->visible_for_hit_testing())
continue;
return result;
}
return HitTestResult { *this };
} }
Optional<HitTestResult> PaintableWithLines::hit_test(Gfx::FloatPoint const& position, HitTestType type) const Optional<HitTestResult> PaintableWithLines::hit_test(Gfx::FloatPoint const& position, HitTestType type) const