RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-14 19:57:36 +00:00
Code Issues Activity Actions

LibWeb: Handle <relative-size> values in the font-size CSS property

Browse source
This commit is contained in:
Mateusz Górzyński 2022-11-30 16:56:33 +01:00 • committed by Sam Atkins
parent a551e02e5e
commit 4dfdca74e2
1 changed files with 14 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Userland/Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -1022,14 +1022,24 @@ void StyleComputer::compute_font(StyleProperties& style, DOM::Element const* ele
{ CSS::ValueID::XLarge, 1.5 }, { CSS::ValueID::XLarge, 1.5 },
{ CSS::ValueID::XxLarge, 2.0 }, { CSS::ValueID::XxLarge, 2.0 },
{ CSS::ValueID::XxxLarge, 3.0 }, { CSS::ValueID::XxxLarge, 3.0 },
{ CSS::ValueID::Smaller, 0.8 },
{ CSS::ValueID::Larger, 1.25 },
}; };
auto const identifier = static_cast<IdentifierStyleValue const&>(*font_size).id(); auto const identifier = static_cast<IdentifierStyleValue const&>(*font_size).id();
// https://w3c.github.io/csswg-drafts/css-fonts/#valdef-font-size-relative-size
// TODO: If the parent element has a keyword font size in the absolute size keyword mapping table,
// larger may compute the font size to the next entry in the table,
// and smaller may compute the font size to the previous entry in the table.
if (identifier == CSS::ValueID::Smaller || identifier == CSS::ValueID::Larger) { if (identifier == CSS::ValueID::Smaller || identifier == CSS::ValueID::Larger) {
// FIXME: Should be based on parent element if (parent_element && parent_element->computed_css_values()) {
} else { font_size_in_px = parent_element->computed_css_values()->computed_font().pixel_metrics().size;
auto const multiplier = absolute_size_mapping.get(identifier).value_or(1.0); }
font_size_in_px *= multiplier;
} }
auto const multiplier = absolute_size_mapping.get(identifier).value_or(1.0);
font_size_in_px *= multiplier;
} else { } else {
float root_font_size = root_element_font_size(); float root_font_size = root_element_font_size();