From 4e32f0d39fea99f2ed86d2300a396600aed301a2 Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Thu, 31 Aug 2023 15:00:09 -0400 Subject: [PATCH] LibWeb: Remove virtual specifier from Element::set/remove_attribute() Only HTMLDetailsElement was overriding these methods, which has been updated to use Element::attribute_changed() instead. --- Userland/Libraries/LibWeb/DOM/Element.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibWeb/DOM/Element.h b/Userland/Libraries/LibWeb/DOM/Element.h index 68d06de00f..5cdf15c1e4 100644 --- a/Userland/Libraries/LibWeb/DOM/Element.h +++ b/Userland/Libraries/LibWeb/DOM/Element.h @@ -103,14 +103,14 @@ public: DeprecatedString get_attribute(DeprecatedFlyString const& name) const; DeprecatedString get_attribute_value(DeprecatedFlyString const& local_name, DeprecatedFlyString const& namespace_ = {}) const; - virtual WebIDL::ExceptionOr set_attribute(DeprecatedFlyString const& name, DeprecatedString const& value); + WebIDL::ExceptionOr set_attribute(DeprecatedFlyString const& name, DeprecatedString const& value); WebIDL::ExceptionOr set_attribute(DeprecatedFlyString const& name, Optional const& value); WebIDL::ExceptionOr set_attribute_ns(DeprecatedFlyString const& namespace_, DeprecatedFlyString const& qualified_name, DeprecatedString const& value); void set_attribute_value(DeprecatedFlyString const& local_name, DeprecatedString const& value, DeprecatedFlyString const& prefix = {}, DeprecatedFlyString const& namespace_ = {}); WebIDL::ExceptionOr> set_attribute_node(Attr&); WebIDL::ExceptionOr> set_attribute_node_ns(Attr&); - virtual void remove_attribute(DeprecatedFlyString const& name); + void remove_attribute(DeprecatedFlyString const& name); WebIDL::ExceptionOr toggle_attribute(DeprecatedFlyString const& name, Optional force); size_t attribute_list_size() const; NamedNodeMap const* attributes() const { return m_attributes.ptr(); }