RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 04:58:13 +00:00
Code Issues Activity Actions

LibWeb: Set select element text when an option is initially selected

Browse source 
Previously, a select element's text would initially be empty if the
`selected` property was set on one of its options.
This commit is contained in:
Tim Ledbetter 2024-01-29 17:52:30 +00:00 • committed by Sam Atkins
parent 002eb0ad03
commit 4e383bdac1
3 changed files with 32 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

26
Tests/LibWeb/Layout/expected/select-with-option-selected.txt Normal file
View file

@ -0,0 +1,26 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x37 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x21 children: inline
frag 0 from BlockContainer start: 0, length: 0, rect: [13,10 89.109375x17] baseline: 16.5
BlockContainer <select> at (13,10) content-size 89.109375x17 inline-block [BFC] children: not-inline
Box <div> at (13,10) content-size 89.109375x17 flex-container(row) [FFC] children: not-inline
BlockContainer <div> at (13,10) content-size 69.109375x17 flex-item [BFC] children: inline
frag 0 from TextNode start: 0, length: 8, rect: [13,10 69.109375x17] baseline: 13.296875
"Option 2"
TextNode <#text>
BlockContainer <div> at (86.109375,10.5) content-size 16x16 flex-item [BFC] children: inline
frag 0 from SVGSVGBox start: 0, length: 0, rect: [86.109375,10.5 16x16] baseline: 16
SVGSVGBox <svg> at (86.109375,10.5) content-size 16x16 [SVG] children: not-inline
SVGGeometryBox <path> at (90.109375,16.21875) content-size 8x4.953125 children: not-inline
TextNode <#text>
ViewportPaintable (Viewport<#document>) [0,0 800x600]
PaintableWithLines (BlockContainer<HTML>) [0,0 800x37]
PaintableWithLines (BlockContainer<BODY>) [8,8 784x21]
PaintableWithLines (BlockContainer<SELECT>) [8,8 99.109375x21]
PaintableBox (Box<DIV>) [13,10 89.109375x17]
PaintableWithLines (BlockContainer<DIV>) [13,10 69.109375x17]
TextPaintable (TextNode<#text>)
PaintableWithLines (BlockContainer<DIV>) [86.109375,10.5 16x16]
SVGSVGPaintable (SVGSVGBox<svg>) [86.109375,10.5 16x16]
SVGPathPaintable (SVGGeometryBox<path>) [90.109375,16.21875 8x4.953125]

5
Tests/LibWeb/Layout/input/select-with-option-selected.html Normal file
View file

@ -0,0 +1,5 @@
<!DOCTYPE html>
<select>
<option>Option 1</option>
<option selected="selected">Option 2</option>
</select>

2
Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View file

@ -323,9 +323,9 @@ void HTMLSelectElement::form_associated_element_was_inserted()
auto options = list_of_options(); auto options = list_of_options();
if (options.size() > 0) { if (options.size() > 0) {
options.at(0)->set_selected(true); options.at(0)->set_selected(true);
update_inner_text_element();
} }
} }
update_inner_text_element();
}); });
} }