RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 06:07:34 +00:00
Code Issues Activity Actions

TextEditor: Remove wordiness and a separator in View menu

Browse source 
In many cases we can lean on the name of a menu to reduce verbosity.
"View"->"Visualize/Show/Turn on/etc" is a bit redundant and clutters
the menu. It's a little thing, but it makes the system feel more
tightly integrated if we stick to the same word patterns across apps.
This commit is contained in:
thankyouverycool 2021-09-11 11:30:03 -04:00 • committed by Andreas Kling
parent 9a5a9fbee0
commit 4e40eaf34c
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Applications/TextEditor/MainWidget.cpp
View file

@ -478,8 +478,6 @@ void MainWidget::initialize_menubar(GUI::Window& window)
m_no_wrapping_action->set_checked(true);
view_menu.add_separator();
m_soft_tab_width_actions.set_exclusive(true);
auto& soft_tab_width_menu = view_menu.add_submenu("&Tab Width");
m_soft_tab_1_width_action = GUI::Action::create_checkable("1", [&](auto&) {
@ -514,14 +512,16 @@ void MainWidget::initialize_menubar(GUI::Window& window)
view_menu.add_separator();
m_visualize_trailing_whitespace_action = GUI::Action::create_checkable("&Visualize Trailing Whitespace", [&](auto&) {
m_visualize_trailing_whitespace_action = GUI::Action::create_checkable("T&railing Whitespace", [&](auto&) {
m_editor->set_visualize_trailing_whitespace(m_visualize_trailing_whitespace_action->is_checked());
});
m_visualize_leading_whitespace_action = GUI::Action::create_checkable("Visualize &Leading Whitespace", [&](auto&) {
m_visualize_leading_whitespace_action = GUI::Action::create_checkable("L&eading Whitespace", [&](auto&) {
m_editor->set_visualize_leading_whitespace(m_visualize_leading_whitespace_action->is_checked());
});
m_visualize_trailing_whitespace_action->set_checked(true);
m_visualize_trailing_whitespace_action->set_status_tip("Visualize trailing whitespace");
m_visualize_leading_whitespace_action->set_status_tip("Visualize leading whitespace");
view_menu.add_action(*m_visualize_trailing_whitespace_action);
view_menu.add_action(*m_visualize_leading_whitespace_action);