RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 06:38:10 +00:00
Code Issues Activity Actions

Services: Fix visibility of Object-derivative constructors

Browse source 
Derivatives of Core::Object should be constructed through
ClassName::construct(), to avoid handling ref-counted objects with
refcount zero. Fixing the visibility means that misuses like this are
more difficult.
This commit is contained in:
Ben Wiederhake 2021-10-31 23:38:04 +01:00 • committed by Andreas Kling
parent b3e9a4e603
commit 4e55d649d7
19 changed files with 45 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Services/WindowServer/MenuManager.h
View file

@ -20,7 +20,6 @@ class MenuManager final : public Core::Object {
public:
static MenuManager& the();
MenuManager();
virtual ~MenuManager() override;
bool is_open(const Menu&) const;
@ -48,6 +47,8 @@ public:
Menu* hovered_menu() { return m_hovered_menu; }
private:
MenuManager();
void close_menus(const Vector<Menu&>&);
virtual void event(Core::Event&) override;