RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 06:27:45 +00:00
Code Issues Activity Actions

Services: Fix visibility of Object-derivative constructors

Browse source 
Derivatives of Core::Object should be constructed through
ClassName::construct(), to avoid handling ref-counted objects with
refcount zero. Fixing the visibility means that misuses like this are
more difficult.
This commit is contained in:
Ben Wiederhake 2021-10-31 23:38:04 +01:00 • committed by Andreas Kling
parent b3e9a4e603
commit 4e55d649d7
19 changed files with 45 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Services/WindowServer/WindowManager.h
View file

@ -68,7 +68,6 @@ public:
static WindowManager& the();
explicit WindowManager(Gfx::PaletteImpl const&);
virtual ~WindowManager() override;
Palette palette() const { return Palette(*m_palette); }
@ -322,6 +321,8 @@ public:
void apply_cursor_theme(String const& name);
private:
explicit WindowManager(Gfx::PaletteImpl const&);
void notify_new_active_window(Window&);
void notify_new_active_input_window(Window&);
void notify_previous_active_window(Window&);