From 4e6fb65ea30181c17cee5598d8318e5ffedea8b4 Mon Sep 17 00:00:00 2001 From: Simon Wanner Date: Mon, 20 Mar 2023 23:48:59 +0100 Subject: [PATCH] LibWeb: Pass scope in ParentNode::query_selector --- Userland/Libraries/LibWeb/DOM/ParentNode.cpp | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/Userland/Libraries/LibWeb/DOM/ParentNode.cpp b/Userland/Libraries/LibWeb/DOM/ParentNode.cpp index 0cce06ddd6..1f4bbb9104 100644 --- a/Userland/Libraries/LibWeb/DOM/ParentNode.cpp +++ b/Userland/Libraries/LibWeb/DOM/ParentNode.cpp @@ -17,19 +17,29 @@ namespace Web::DOM { +// https://dom.spec.whatwg.org/#dom-parentnode-queryselector WebIDL::ExceptionOr> ParentNode::query_selector(StringView selector_text) { + // The querySelector(selectors) method steps are to return the first result of running scope-match a selectors string selectors against this, + // if the result is not an empty list; otherwise null. + + // https://dom.spec.whatwg.org/#scope-match-a-selectors-string + // To scope-match a selectors string selectors against a node, run these steps: + // 1. Let s be the result of parse a selector selectors. auto maybe_selectors = parse_selector(CSS::Parser::ParsingContext(*this), selector_text); + + // 2. If s is failure, then throw a "SyntaxError" DOMException. if (!maybe_selectors.has_value()) return WebIDL::SyntaxError::create(realm(), "Failed to parse selector"); auto selectors = maybe_selectors.value(); + // 3. Return the result of match a selector against a tree with s and node’s root using scoping root node. JS::GCPtr result; // FIXME: This should be shadow-including. https://drafts.csswg.org/selectors-4/#match-a-selector-against-a-tree for_each_in_subtree_of_type([&](auto& element) { for (auto& selector : selectors) { - if (SelectorEngine::matches(selector, element)) { + if (SelectorEngine::matches(selector, element, {}, this)) { result = &element; return IterationDecision::Break; }