1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:37:35 +00:00

LibJS: Parse arrow function expression with correct precedence

The parser was chomping on commas present after the arrow function expression. eg. [x=>x,2] would parse as [x=>(x,2)] instead of [(x=>x),2].

This is not the case anymore. I've added a small test to prove this.
This commit is contained in:
Marcin Gasperowicz 2020-05-29 22:03:47 +02:00 committed by Andreas Kling
parent 20faa93cb0
commit 4e8de753c9
3 changed files with 7 additions and 5 deletions

View file

@ -370,7 +370,7 @@ RefPtr<FunctionExpression> Parser::try_parse_arrow_function_expression(bool expe
// for arrow function bodies which are a single expression.
// Esprima generates a single "ArrowFunctionExpression"
// with a "body" property.
auto return_expression = parse_expression(0);
auto return_expression = parse_expression(2);
auto return_block = create_ast_node<BlockStatement>();
return_block->append<ReturnStatement>(move(return_expression));
return return_block;
@ -848,8 +848,7 @@ NonnullRefPtr<Expression> Parser::parse_secondary_expression(NonnullRefPtr<Expre
syntax_error(
String::format("'%s' cannot be assigned to in strict mode code", name.characters()),
m_parser_state.m_current_token.line_number(),
m_parser_state.m_current_token.line_column()
);
m_parser_state.m_current_token.line_column());
}
}
return create_ast_node<AssignmentExpression>(AssignmentOp::Assignment, move(lhs), parse_expression(min_precedence, associativity));

View file

@ -67,8 +67,7 @@ try {
result = [5, 4, 3, 2, 1].reduce((accum, elem) => accum + elem);
assert(result === 15);
// likely parser bug: arrow func parser eats ", 100" as a part of the function, hence the parens
result = [1, 2, 3, 4, 5, 6].reduce(((accum, elem) => accum + elem), 100);
result = [1, 2, 3, 4, 5, 6].reduce((accum, elem) => accum + elem, 100);
assert(result === 121);
result = [6, 5, 4, 3, 2, 1].reduce((accum, elem) => { return accum + elem }, 100);

View file

@ -16,6 +16,10 @@ try {
};
assert(addBlock(5, 4) === 9);
let chompy = [(x) => x, 2];
assert(chompy.length === 2);
assert(chompy[0](1) === 1);
const makeObject = (a, b) => ({ a, b });
const obj = makeObject(33, 44);
assert(typeof obj === "object");