RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 12:47:41 +00:00
Code Issues Activity Actions

LibJS/JIT: Compile the GetPrivateById instruction

Browse source
This commit is contained in:
Simon Wanner 2023-10-29 21:24:50 +01:00 • committed by Andreas Kling
parent 4ce2878394
commit 4e9edb8c53
3 changed files with 21 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -621,6 +621,8 @@ public:
ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const; ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const;
DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const; DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const;
IdentifierTableIndex property() const { return m_property; }
private: private:
IdentifierTableIndex m_property; IdentifierTableIndex m_property;
}; };

17
Userland/Libraries/LibJS/JIT/Compiler.cpp
View file

@ -1395,6 +1395,23 @@ void Compiler::compile_get_object_property_iterator(Bytecode::Op::GetObjectPrope
check_exception(); check_exception();
} }
static Value cxx_get_private_by_id(VM& vm, Value base_value, DeprecatedFlyString& name)
{
auto private_reference = make_private_reference(vm, base_value, name);
return TRY_OR_SET_EXCEPTION(private_reference.get_value(vm));
}
void Compiler::compile_get_private_by_id(Bytecode::Op::GetPrivateById const& op)
{
load_vm_register(ARG1, Bytecode::Register::accumulator());
m_assembler.mov(
Assembler::Operand::Register(ARG2),
Assembler::Operand::Imm(bit_cast<u64>(&m_bytecode_executable.get_identifier(op.property()))));
native_call((void*)cxx_get_private_by_id);
store_vm_register(Bytecode::Register::accumulator(), RET);
check_exception();
}
void Compiler::jump_to_exit() void Compiler::jump_to_exit()
{ {
m_assembler.jump(m_exit_label); m_assembler.jump(m_exit_label);

3
Userland/Libraries/LibJS/JIT/Compiler.h
View file

@ -119,7 +119,8 @@ private:
O(DeleteById, delete_by_id) \ O(DeleteById, delete_by_id) \
O(DeleteByValue, delete_by_value) \ O(DeleteByValue, delete_by_value) \
O(DeleteByValueWithThis, delete_by_value_with_this) \ O(DeleteByValueWithThis, delete_by_value_with_this) \
O(GetObjectPropertyIterator, get_object_property_iterator) O(GetObjectPropertyIterator, get_object_property_iterator) \
O(GetPrivateById, get_private_by_id)
# define DECLARE_COMPILE_OP(OpTitleCase, op_snake_case) \ # define DECLARE_COMPILE_OP(OpTitleCase, op_snake_case) \
void compile_##op_snake_case(Bytecode::Op::OpTitleCase const&); void compile_##op_snake_case(Bytecode::Op::OpTitleCase const&);