RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 09:27:35 +00:00
Code Issues Activity Actions

LibJS: Store basic traceback in Exception

Browse source 
Nothing fancy like line numbers, but Exception now stores a list of
function names up to the current call frame.
This commit is contained in:
Linus Groh 2020-06-02 14:11:59 +01:00 • committed by Andreas Kling
parent a48080f62d
commit 4f6912c605
2 changed files with 10 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibJS/Runtime/Exception.cpp
View file

@ -24,6 +24,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/ */
#include <LibJS/Interpreter.h>
#include <LibJS/Runtime/Exception.h> #include <LibJS/Runtime/Exception.h>
namespace JS { namespace JS {
@ -31,6 +32,13 @@ namespace JS {
Exception::Exception(Value value) Exception::Exception(Value value)
: m_value(value) : m_value(value)
{ {
auto call_stack = interpreter().call_stack();
for (ssize_t i = call_stack.size() - 1; i >= 0; --i) {
auto function_name = call_stack[i].function_name;
if (function_name.is_empty())
function_name = "<anonymous>";
m_trace.append(function_name);
}
} }
Exception::~Exception() Exception::~Exception()

2
Libraries/LibJS/Runtime/Exception.h
View file

@ -37,12 +37,14 @@ public:
virtual ~Exception() override; virtual ~Exception() override;
Value value() const { return m_value; } Value value() const { return m_value; }
const Vector<String>& trace() const { return m_trace; }
private: private:
virtual const char* class_name() const override { return "Exception"; } virtual const char* class_name() const override { return "Exception"; }
virtual void visit_children(Visitor&) override; virtual void visit_children(Visitor&) override;
Value m_value; Value m_value;
Vector<String> m_trace;
}; };
} }