RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:17:44 +00:00
Code Issues Activity Actions

LibWeb: Only derive baseline from children with a non-empty line box

Browse source 
If none of the box children have a baseline set, the bottom margin
edge of the box is used as the baseline.
This commit is contained in:
Christophe Naud-Dulude 2023-07-28 09:58:01 -04:00 • committed by Andreas Kling
parent 38edab09a0
commit 4f9f21e8fe
10 changed files with 84 additions and 62 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibWeb/Layout/expected/svg/svg-negative-elliptical-arg-number.txt
View file

@ -1,7 +1,7 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x116 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x100 children: inline
line 0 width: 100, height: 100, bottom: 100, baseline: 48
line 0 width: 100, height: 100, bottom: 100, baseline: 100
frag 0 from SVGSVGBox start: 0, length: 0, rect: [8,8 100x100]
SVGSVGBox <svg> at (8,8) content-size 100x100 [SVG] children: not-inline
SVGGeometryBox <path> at (8,9.984375) content-size 100x48 children: not-inline

2
Tests/LibWeb/Layout/expected/svg/svg-path-with-implicit-lineto.txt
View file

@ -1,7 +1,7 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x116 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x100 children: inline
line 0 width: 100, height: 100, bottom: 100, baseline: 60
line 0 width: 100, height: 100, bottom: 100, baseline: 100
frag 0 from SVGSVGBox start: 0, length: 0, rect: [8,8 100x100]
SVGSVGBox <svg> at (8,8) content-size 100x100 [SVG] children: not-inline
SVGGeometryBox <path> at (28,28) content-size 60x60 children: not-inline

2
Tests/LibWeb/Layout/expected/svg/svg-with-css-variable-in-presentation-hint.txt
View file

@ -1,7 +1,7 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x118 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x102 children: inline
line 0 width: 102, height: 102, bottom: 102, baseline: 60
line 0 width: 102, height: 102, bottom: 102, baseline: 102
frag 0 from SVGSVGBox start: 0, length: 0, rect: [9,9 100x100]
SVGSVGBox <svg> at (9,9) content-size 100x100 [SVG] children: not-inline
SVGGeometryBox <rect> at (29,29) content-size 60x60 children: not-inline

10
Tests/LibWeb/Layout/expected/svg/text-fill-none.txt
View file

@ -1,8 +1,8 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x600 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x163.53125 children: inline
line 0 width: 300, height: 163.53125, bottom: 163.53125, baseline: 13.53125
frag 0 from SVGSVGBox start: 0, length: 0, rect: [8,21.53125 300x150]
SVGSVGBox <svg> at (8,21.53125) content-size 300x150 [SVG] children: not-inline
SVGTextBox <text> at (8,21.53125) content-size 0x0 children: not-inline
BlockContainer <body> at (8,8) content-size 784x150 children: inline
line 0 width: 300, height: 150, bottom: 150, baseline: 150
frag 0 from SVGSVGBox start: 0, length: 0, rect: [8,8 300x150]
SVGSVGBox <svg> at (8,8) content-size 300x150 [SVG] children: not-inline
SVGTextBox <text> at (8,8) content-size 0x0 children: not-inline
TextNode <#text>