RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-08-06 20:17:36 +00:00
Code Issues Activity Actions

Userland: Remove workarounds for LibIPC include order sensitivity

Browse source
This commit is contained in:
Timothy Flynn 2022-11-15 11:32:00 -05:00 • committed by Tim Flynn
parent 05f41382bb
commit 4fd9e3ab08
17 changed files with 11 additions and 46 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/Browser/Tab.h
View file

@ -14,8 +14,6 @@
#include <LibGUI/Widget.h>
#include <LibGfx/ShareableBitmap.h>
#include <LibHTTP/Job.h>
#include <LibWeb/Cookie/Cookie.h>
#include <LibWeb/Cookie/ParsedCookie.h>
#include <LibWeb/Forward.h>
namespace WebView {

4
Userland/Applications/DisplaySettings/BackgroundSettingsWidget.cpp
View file

@ -9,6 +9,7 @@
#include "BackgroundSettingsWidget.h"
#include <AK/StringBuilder.h>
#include <Applications/DisplaySettings/BackgroundSettingsGML.h>
#include <LibConfig/Client.h>
#include <LibCore/ConfigFile.h>
#include <LibDesktop/Launcher.h>
#include <LibGUI/Application.h>
@ -26,9 +27,6 @@
#include <LibGfx/Palette.h>
#include <LibGfx/SystemTheme.h>
// Including this after to avoid LibIPC errors
#include <LibConfig/Client.h>
namespace DisplaySettings {
BackgroundSettingsWidget::BackgroundSettingsWidget(bool& background_settings_changed)

4
Userland/Applications/KeyboardSettings/main.cpp
View file

@ -6,15 +6,13 @@
*/
#include "KeyboardSettingsWidget.h"
#include <LibConfig/Client.h>
#include <LibCore/ArgsParser.h>
#include <LibCore/System.h>
#include <LibGUI/Application.h>
#include <LibGUI/SettingsWindow.h>
#include <LibMain/Main.h>
// Including this after to avoid LibIPC errors
#include <LibConfig/Client.h>
ErrorOr<int> serenity_main(Main::Arguments arguments)
{
TRY(Core::System::pledge("stdio rpath recvfd sendfd unix proc exec"));

4
Userland/Applications/SoundPlayer/main.cpp
View file

@ -5,9 +5,6 @@
* SPDX-License-Identifier: BSD-2-Clause
*/
// FIXME: LibIPC Decoder and Encoder are sensitive to include order here
#include <LibImageDecoderClient/Client.h>
#include "AlbumCoverVisualizationWidget.h"
#include "BarsVisualizationWidget.h"
#include "Player.h"
@ -24,6 +21,7 @@
#include <LibGUI/Menubar.h>
#include <LibGUI/Window.h>
#include <LibGfx/CharacterBitmap.h>
#include <LibImageDecoderClient/Client.h>
#include <LibMain/Main.h>
ErrorOr<int> serenity_main(Main::Arguments arguments)

4
Userland/Applications/TerminalSettings/main.cpp
View file

@ -5,6 +5,7 @@
*/
#include "TerminalSettingsWidget.h"
#include <LibConfig/Client.h>
#include <LibCore/ArgsParser.h>
#include <LibCore/System.h>
#include <LibGUI/Application.h>
@ -12,9 +13,6 @@
#include <LibGUI/SettingsWindow.h>
#include <LibMain/Main.h>
// Including this after to avoid LibIPC errors
#include <LibConfig/Client.h>
ErrorOr<int> serenity_main(Main::Arguments arguments)
{
TRY(Core::System::pledge("stdio rpath recvfd sendfd unix"));

5
Userland/Applications/ThemeEditor/MainWidget.cpp
View file

@ -15,15 +15,12 @@
#include <Applications/ThemeEditor/MetricPropertyGML.h>
#include <Applications/ThemeEditor/PathPropertyGML.h>
#include <Applications/ThemeEditor/ThemeEditorGML.h>
// FIXME: LibIPC Decoder and Encoder are sensitive to include order here
// clang-format off
#include <LibGUI/ConnectionToWindowServer.h>
// clang-format on
#include <LibFileSystemAccessClient/Client.h>
#include <LibGUI/ActionGroup.h>
#include <LibGUI/Application.h>
#include <LibGUI/BoxLayout.h>
#include <LibGUI/Button.h>
#include <LibGUI/ConnectionToWindowServer.h>
#include <LibGUI/FilePicker.h>
#include <LibGUI/Frame.h>
#include <LibGUI/GroupBox.h>