RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:57:35 +00:00
Code Issues Activity Actions

HackStudio: Stop crash from leaking Editor widgets when closing tabs

Browse source 
When re-opening an existing file, we would reuse the document and
register a new Editor with it, but never unregister that Editor.

Previously, this would cause a crash if you opened a binary file, closed
its tab, then opened that binary file again. HackStudio would crash
while calling `HackStudio::EditorWrapper::update_title()` on an invalid
EditorWrapper. But now it doesn't!

Something still gets leaked each time, but we now don't crash at least.
This commit is contained in:
Sam Atkins 2024-01-12 17:23:59 +00:00 • committed by Andrew Kaster
parent 284f14d046
commit 4ffd43a5f4
1 changed files with 1 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Userland/DevTools/HackStudio/HackStudioWidget.cpp
View file

@ -801,6 +801,7 @@ void HackStudioWidget::add_new_editor(GUI::TabWidget& parent)
wrapper.on_tab_close_request = [this, &parent](auto& tab) { wrapper.on_tab_close_request = [this, &parent](auto& tab) {
parent.deferred_invoke([this, &parent, &tab] { parent.deferred_invoke([this, &parent, &tab] {
tab.editor().document().unregister_client(tab.editor());
set_current_editor_wrapper(tab); set_current_editor_wrapper(tab);
parent.remove_tab(tab); parent.remove_tab(tab);
m_all_editor_wrappers.remove_first_matching([&tab](auto& entry) { return entry == &tab; }); m_all_editor_wrappers.remove_first_matching([&tab](auto& entry) { return entry == &tab; });