RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 07:37:35 +00:00
Code Issues Activity Actions

LibCore+Everywhere: Remove ArgsParser::add*(char const*&)

Browse source 
This is not guaranteed to always work correctly as ArgsParser deals in
StringViews and might have a non-properly-null-terminated string as a
value. As a bonus, using StringView (and DeprecatedString where
necessary) leads to nicer looking code too :^)
This commit is contained in:
Ali Mohammad Pur 2023-03-01 00:11:43 +03:30 • committed by Andreas Kling
parent 60908adcbe
commit 500044906d
43 changed files with 122 additions and 145 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Tests/LibJS/test-test262.cpp
View file

@ -305,7 +305,7 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
StringView per_file_location;
StringView pass_through_parameters;
StringView runner_command = "test262-runner"sv;
char const* test_directory = nullptr;
StringView test_directory;
bool dont_print_progress = false;
bool dont_disable_core_dump = false;