RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 04:57:45 +00:00
Code Issues Activity Actions

LibCore+Everywhere: Remove ArgsParser::add*(char const*&)

Browse source 
This is not guaranteed to always work correctly as ArgsParser deals in
StringViews and might have a non-properly-null-terminated string as a
value. As a bonus, using StringView (and DeprecatedString where
necessary) leads to nicer looking code too :^)
This commit is contained in:
Ali Mohammad Pur 2023-03-01 00:11:43 +03:30 • committed by Andreas Kling
parent 60908adcbe
commit 500044906d
43 changed files with 122 additions and 145 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibTest/JavaScriptTestRunnerMain.cpp
View file

@ -94,7 +94,7 @@ int main(int argc, char** argv)
#endif
bool print_json = false;
bool per_file = false;
char const* specified_test_root = nullptr;
StringView specified_test_root;
DeprecatedString common_path;
DeprecatedString test_glob;
@ -143,7 +143,7 @@ int main(int argc, char** argv)
DeprecatedString test_root;
if (specified_test_root) {
if (!specified_test_root.is_empty()) {
test_root = DeprecatedString { specified_test_root };
} else {
#ifdef AK_OS_SERENITY

2
Userland/Libraries/LibTest/TestSuite.cpp
View file

@ -65,7 +65,7 @@ int TestSuite::main(DeprecatedString const& suite_name, Span<StringView> argumen
bool do_tests_only = getenv("TESTS_ONLY") != nullptr;
bool do_benchmarks_only = false;
bool do_list_cases = false;
char const* search_string = "*";
StringView search_string = "*"sv;
args_parser.add_option(do_tests_only, "Only run tests.", "tests", 0);
args_parser.add_option(do_benchmarks_only, "Only run benchmarks.", "bench", 0);