RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 11:27:34 +00:00
Code Issues Activity Actions

LibCore: Remove Stream::is_{readable,writable}

Browse source 
Next to functions like `is_eof` these were really confusing to use, and
the `read`/`write` functions should fail anyways if a stream is not
readable/writable.
This commit is contained in:
Tim Schumacher 2022-12-11 17:15:48 +01:00 • committed by Andreas Kling
parent 5a346c4297
commit 5061a905ff
7 changed files with 1 additions and 32 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibCore/InputBitStream.h
View file

@ -30,7 +30,6 @@ public:
}
// ^Stream
virtual bool is_readable() const override { return m_stream.is_readable(); }
virtual ErrorOr<Bytes> read(Bytes bytes) override
{
if (m_current_byte.has_value() && is_aligned_to_byte_boundary()) {
@ -40,7 +39,6 @@ public:
align_to_byte_boundary();
return m_stream.read(bytes);
}
virtual bool is_writable() const override { return m_stream.is_writable(); }
virtual ErrorOr<size_t> write(ReadonlyBytes bytes) override { return m_stream.write(bytes); }
virtual bool write_or_error(ReadonlyBytes bytes) override { return m_stream.write_or_error(bytes); }
virtual bool is_eof() const override { return m_stream.is_eof() && !m_current_byte.has_value(); }
@ -147,7 +145,6 @@ public:
}
// ^Stream
virtual bool is_readable() const override { return m_stream.is_readable(); }
virtual ErrorOr<Bytes> read(Bytes bytes) override
{
if (m_current_byte.has_value() && is_aligned_to_byte_boundary()) {
@ -157,7 +154,6 @@ public:
align_to_byte_boundary();
return m_stream.read(bytes);
}
virtual bool is_writable() const override { return m_stream.is_writable(); }
virtual ErrorOr<size_t> write(ReadonlyBytes bytes) override { return m_stream.write(bytes); }
virtual bool write_or_error(ReadonlyBytes bytes) override { return m_stream.write_or_error(bytes); }
virtual bool is_eof() const override { return m_stream.is_eof() && !m_current_byte.has_value(); }