RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 15:57:34 +00:00
Code Issues Activity Actions

HackStudio: Put the Build directory inside the Serenity repository

Browse source 
Previously, the build directory for building serenity components was a
temporary directory in /tmp which was generated whenever a different
serenity component was built.

Instead of doing that, Hack Studio now simply uses the Build/ directory
inside the Serenity repository, similar to what is done in host builds.

This makes it so we don't re-build when switching back and forth between
different components.
It also makes it easier to inspect the build products.
This commit is contained in:
Itamar 2022-02-12 12:02:42 +02:00 • committed by Andreas Kling
parent 83688d0610
commit 506c13d143
2 changed files with 17 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/DevTools/HackStudio/ProjectBuilder.h
View file

@ -36,6 +36,7 @@ private:
Optional<String> find_cmake_file_for(StringView file_path) const;
String generate_cmake_file_content() const;
ErrorOr<void> update_active_file(StringView active_file);
String build_directory() const;
struct LibraryInfo {
String path;
@ -50,7 +51,6 @@ private:
String m_project_root;
NonnullRefPtr<TerminalWrapper> m_terminal;
IsSerenityRepo m_is_serenity { IsSerenityRepo::No };
OwnPtr<Core::TempFile> m_build_directory;
String m_serenity_component_cmake_file;
String m_serenity_component_name;
};