RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:57:34 +00:00
Code Issues Activity Actions

LibWeb: Evaluate @media rules

Browse source 
We now evaluate the conditions of `@media` rules at the same point in
the HTML event loop as evaluation of `MediaQueryList`s. This is not
strictly to spec, but since the spec doesn't actually say when to do
this, it seems to make the most sense. In any case, it works! :^)
This commit is contained in:
Sam Atkins 2021-10-08 20:21:46 +01:00 • committed by Andreas Kling
parent 57a25139a5
commit 5098cd22a4
8 changed files with 47 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/CSS/CSSMediaRule.h
View file

@ -30,11 +30,12 @@ public:
virtual String condition_text() const override;
virtual void set_condition_text(String) override;
// FIXME: We need to evaluate() the query before matches() will work!
virtual bool condition_matches() const override { return m_media->matches(); }
NonnullRefPtr<MediaList> const& media() const { return m_media; }
bool evaluate(DOM::Window const& window) { return m_media->evaluate(window); }
private:
explicit CSSMediaRule(NonnullRefPtr<MediaList>&&, NonnullRefPtrVector<CSSRule>&&);