RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:47:45 +00:00
Code Issues Activity Actions

AK: Inline the bucket index calculation

Browse source 
The result of the modulo is only used in the array index, so why
make the code more complex by calculating it in two different places?
This commit is contained in:
thislooksfun 2021-04-01 20:52:32 -05:00 • committed by Andreas Kling
parent 8fb7739cfb
commit 509eb10df4
1 changed files with 3 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

9
AK/HashTable.h
View file

@ -308,9 +308,9 @@ private:
{
if (is_empty())
return nullptr;
size_t bucket_index = hash % m_capacity;
for (;;) {
auto& bucket = m_buckets[bucket_index];
auto& bucket = m_buckets[hash % m_capacity];
if (usable_bucket_for_writing && !*usable_bucket_for_writing && !bucket.used) {
*usable_bucket_for_writing = &bucket;
@ -323,7 +323,6 @@ private:
return nullptr;
hash = double_hash(hash);
bucket_index = hash % m_capacity;
}
}
@ -348,14 +347,12 @@ private:
else if (usable_bucket_for_writing)
return *usable_bucket_for_writing;
size_t bucket_index = hash % m_capacity;
for (;;) {
auto& bucket = m_buckets[bucket_index];
auto& bucket = m_buckets[hash % m_capacity];
if (!bucket.used)
return bucket;
hash = double_hash(hash);
bucket_index = hash % m_capacity;
}
}